From 0622b00741dd01dd653f68aa10a3493b0b264c6d Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Mon, 29 Jun 2026 12:25:11 +0200 Subject: [PATCH] [Set] Extract mock-to-stub rules into dedicated PHPUNIT_MOCK_TO_STUB set --- config/sets/phpunit-mock-to-stub.php | 19 +++++++++++++++++++ config/sets/phpunit120.php | 13 +++---------- src/Set/PHPUnitSetList.php | 2 ++ 3 files changed, 24 insertions(+), 10 deletions(-) create mode 100644 config/sets/phpunit-mock-to-stub.php diff --git a/config/sets/phpunit-mock-to-stub.php b/config/sets/phpunit-mock-to-stub.php new file mode 100644 index 000000000..e1207e946 --- /dev/null +++ b/config/sets/phpunit-mock-to-stub.php @@ -0,0 +1,19 @@ +rules([ + // stubs over mocks + CreateStubOverCreateMockArgRector::class, + CreateStubInCoalesceArgRector::class, + ExpressionCreateMockToCreateStubRector::class, + PropertyCreateMockToCreateStubRector::class, + ]); +}; diff --git a/config/sets/phpunit120.php b/config/sets/phpunit120.php index 1a2c7d94c..946f36305 100644 --- a/config/sets/phpunit120.php +++ b/config/sets/phpunit120.php @@ -3,22 +3,15 @@ declare(strict_types=1); use Rector\Config\RectorConfig; -use Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubInCoalesceArgRector; -use Rector\PHPUnit\PHPUnit120\Rector\CallLike\CreateStubOverCreateMockArgRector; use Rector\PHPUnit\PHPUnit120\Rector\Class_\AssertIsTypeMethodCallRector; -use Rector\PHPUnit\PHPUnit120\Rector\Class_\PropertyCreateMockToCreateStubRector; use Rector\PHPUnit\PHPUnit120\Rector\Class_\RemoveOverrideFinalConstructTestCaseRector; -use Rector\PHPUnit\PHPUnit120\Rector\ClassMethod\ExpressionCreateMockToCreateStubRector; +use Rector\PHPUnit\Set\PHPUnitSetList; return static function (RectorConfig $rectorConfig): void { + $rectorConfig->sets([PHPUnitSetList::PHPUNIT_MOCK_TO_STUB]); + $rectorConfig->rules([ RemoveOverrideFinalConstructTestCaseRector::class, AssertIsTypeMethodCallRector::class, - - // stubs over mocks - CreateStubOverCreateMockArgRector::class, - CreateStubInCoalesceArgRector::class, - ExpressionCreateMockToCreateStubRector::class, - PropertyCreateMockToCreateStubRector::class, ]); }; diff --git a/src/Set/PHPUnitSetList.php b/src/Set/PHPUnitSetList.php index e4b5ed5cb..a72f8020e 100644 --- a/src/Set/PHPUnitSetList.php +++ b/src/Set/PHPUnitSetList.php @@ -27,6 +27,8 @@ final class PHPUnitSetList public const string PHPUNIT_120 = __DIR__ . '/../../config/sets/phpunit120.php'; + public const string PHPUNIT_MOCK_TO_STUB = __DIR__ . '/../../config/sets/phpunit-mock-to-stub.php'; + public const string PHPUNIT_CODE_QUALITY = __DIR__ . '/../../config/sets/phpunit-code-quality.php'; public const string ANNOTATIONS_TO_ATTRIBUTES = __DIR__ . '/../../config/sets/annotations-to-attributes.php';