Skip to content

Fix About page diagnostics#726

Open
ranjeshj wants to merge 1 commit into
openclaw:mainfrom
ranjeshj:user/ranjeshj/fixes
Open

Fix About page diagnostics#726
ranjeshj wants to merge 1 commit into
openclaw:mainfrom
ranjeshj:user/ranjeshj/fixes

Conversation

@ranjeshj

@ranjeshj ranjeshj commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix the About page documentation link to the Windows docs (docs.openclaw.ai/platforms/windows).
  • Replace stale/hard-coded runtime text with values resolved from the running app: .NET runtime, WinUI major version, and full Windows App SDK package version from the app .deps.json (fallback to DLL metadata).
  • Rename Gateway Info Model to Protocol, use source-of-truth log/config paths, harden shell launch failures, and keep uptime fresh while the About page is visible.
  • Update localized About page resources for the corrected runtime placeholder, protocol label, and docs link.

Screenshot / manual verification

The updated About page was manually verified from the provided screenshot. It shows:

  • .NET 10.0.8 / WinUI 3 / Windows App SDK 2.1.3
  • Protocol: v4
  • refreshed uptime (3h 10m in the screenshot)
  • corrected docs link: docs.openclaw.ai/platforms/windows

Screenshot source in this session: C:\Users\ranjeshj\AppData\Local\Temp\copilot-image-102f59.png.

Note: GitHub CLI/REST does not support uploading local binary PR attachments from this environment, so the image itself is not embedded in the PR body.

Code review

Ran two adversarial review rounds (Opus + Codex). Addressed the actionable robustness findings:

  • Hardened Windows App SDK metadata lookup.
  • Hardened shell target handling for empty/malformed targets.
  • Added a visible-page uptime ticker based on the latest gateway uptime sample.

Remaining review notes were low/disputed and intentionally left as-is:

  • Support-context copy is already protected by AsyncEventHandlerGuard.
  • Runtime localization of unknown/duration units is broader existing behavior, not introduced by this fix.

Validation

  • ./build.ps1
  • dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore
  • dotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore

Update the About page to resolve runtime stack versions dynamically, correct the documentation link, rename gateway model to protocol, keep uptime fresh while visible, and use source-of-truth log/config paths.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@clawsweeper

clawsweeper Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed June 8, 2026, 7:02 PM ET / 23:02 UTC.

Summary
The PR updates the WinUI About page to resolve runtime/App SDK diagnostics dynamically, rename gateway Model to Protocol, refresh displayed uptime, use source-of-truth log/config paths, harden shell launching, and update localized resource strings.

Reproducibility: yes. Source inspection shows current main hard-codes stale runtime/App SDK text and the old docs URL while the project references WindowsAppSDK 2.1.3.

Review metrics: 2 noteworthy metrics.

  • Diff scope: 7 files, 237 additions, 75 deletions. The patch is concentrated in the About page code-behind plus matching XAML and resource updates.
  • Localized resources touched: 5 resource files changed. The visible label and docs-link text changes depend on resource consistency across supported locales.

Merge readiness
Overall: 🧂 unranked krab
Proof: 🧂 unranked krab
Patch quality: 🐚 platinum hermit
Result: blocked until stronger real behavior proof is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P1] Attach an inspectable after-fix screenshot or recording of the About page showing the dynamic runtime text, Protocol label, fresh uptime, and Windows docs link, with private details redacted.

Proof guidance:

  • [P1] Needs stronger real behavior proof before merge: The PR claims a screenshot/manual check, but the image is only a local temp path and is not inspectable; add an embedded screenshot/recording or redacted live output, then update the PR body to trigger review or ask a maintainer for @clawsweeper re-review.

Mantis proof suggestion
A short visible desktop proof would directly show the About page diagnostics and docs-link behavior that this PR changes. A maintainer can ask Mantis to capture proof by posting a new PR comment that starts with the OpenClaw Mantis account mention, followed by:

visual task: verify the About page shows dynamic runtime versions, Protocol v4, fresh uptime, and the Windows docs link.

Risk before merge

  • [P1] The after-fix UI proof is not inspectable because the PR body references a local screenshot path rather than an attached artifact; reviewers should ask for an embedded screenshot, recording, redacted logs/live output, or an explicit maintainer override.

Maintainer options:

  1. Decide the mitigation before merge
    Land the focused About page diagnostics fix after inspectable real behavior proof or maintainer override confirms the UI, docs link, and uptime behavior in a real app run.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • [P2] Needs human PR handling because collaborator-authored items should stay open and the only clear blocker is missing inspectable real behavior proof, not an automatable code repair.

Security
Cleared: The diff only changes About page diagnostics, local metadata reading, and fixed shell targets; I found no concrete security or supply-chain regression.

Review details

Best possible solution:

Land the focused About page diagnostics fix after inspectable real behavior proof or maintainer override confirms the UI, docs link, and uptime behavior in a real app run.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection shows current main hard-codes stale runtime/App SDK text and the old docs URL while the project references WindowsAppSDK 2.1.3.

Is this the best way to solve the issue?

Yes, the proposed direction is a narrow maintainable fix for stale diagnostics by reading runtime/package metadata and source-of-truth paths; the remaining blocker is proof/merge handling rather than a known code defect.

AGENTS.md: found and applied where relevant.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 71d249711d63.

Label changes

Label changes:

  • add P3: This is a low-risk diagnostics/About page polish fix with limited user-facing blast radius.
  • add rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
  • add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs stronger real behavior proof before merge: The PR claims a screenshot/manual check, but the image is only a local temp path and is not inspectable; add an embedded screenshot/recording or redacted live output, then update the PR body to trigger review or ask a maintainer for @clawsweeper re-review.

Label justifications:

  • P3: This is a low-risk diagnostics/About page polish fix with limited user-facing blast radius.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs stronger real behavior proof before merge: The PR claims a screenshot/manual check, but the image is only a local temp path and is not inspectable; add an embedded screenshot/recording or redacted live output, then update the PR body to trigger review or ask a maintainer for @clawsweeper re-review.
Evidence reviewed

What I checked:

  • Repository policy read: AGENTS.md was read fully; its validation guidance is relevant because the PR body claims the required build and test commands, while this cleanup review is read-only. (AGENTS.md:1, 71d249711d63)
  • Current main has stale About diagnostics: Current main hard-codes the About page runtime text as .NET 10 / WinUI 3 / WinAppSDK 1.8 and shows the old documentation label. (src/OpenClaw.Tray.WinUI/Pages/AboutPage.xaml:24, 71d249711d63)
  • Project package version differs from About text: The tray project references Microsoft.WindowsAppSDK 2.1.3, so the current About page text that says WinAppSDK 1.8 is stale by source inspection. (src/OpenClaw.Tray.WinUI/OpenClaw.Tray.WinUI.csproj:59, 71d249711d63)
  • PR implements the requested diagnostics update: The PR head sets the docs link to the Windows docs, displays Protocol, resolves runtime/App SDK values from the running app, and adds a visible uptime refresh path. (src/OpenClaw.Tray.WinUI/Pages/AboutPage.xaml.cs:188, 4babd4ac22f7)
  • Real behavior proof gap: The PR body describes manual verification but references only C:\Users\ranjeshj\AppData\Local\Temp\copilot-image-102f59.png; the provided GitHub context has no embedded screenshot or inspectable media. (4babd4ac22f7)
  • Feature history provenance: Blame ties the current About page diagnostics rows and docs handler to the v0.6.3 localization commit, while earlier history shows the About page was introduced by the companion app refactor. (src/OpenClaw.Tray.WinUI/Pages/AboutPage.xaml:53, 85445c78066b)

Likely related people:

  • christineyan4: Current-main blame for the About page XAML/code-behind and localized resource rows points to the v0.6.3 localization commit. (role: recent area contributor; confidence: high; commits: 85445c78066b; files: src/OpenClaw.Tray.WinUI/Pages/AboutPage.xaml, src/OpenClaw.Tray.WinUI/Pages/AboutPage.xaml.cs, src/OpenClaw.Tray.WinUI/Strings/en-us/Resources.resw)
  • Régis Brid: History shows the companion application refactor introduced the About page and HubWindow page initialization surface that this PR modifies. (role: introduced behavior; confidence: medium; commits: f2fa038bd080; files: src/OpenClaw.Tray.WinUI/Pages/AboutPage.xaml, src/OpenClaw.Tray.WinUI/Pages/AboutPage.xaml.cs, src/OpenClaw.Tray.WinUI/Windows/HubWindow.xaml.cs)
  • bakudies: Recent diagnostics-page history touched About page support-context behavior and tests that are adjacent to this PR's About diagnostics changes. (role: adjacent diagnostics contributor; confidence: medium; commits: 84ceee19c03d; files: src/OpenClaw.Tray.WinUI/Pages/AboutPage.xaml, src/OpenClaw.Tray.WinUI/Pages/AboutPage.xaml.cs, tests/OpenClaw.Tray.Tests/DiagnosticsPageContractTests.cs)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@ranjeshj

ranjeshj commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author
image

@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant