chore(deps): update vite-plus to pkg.pr.new PR #1693#789
Conversation
Update vite-plus, @voidzero-dev/vite-plus-core, and @voidzero-dev/vite-plus-test to the pkg.pr.new build from voidzero-dev/vite-plus#1693 (commit 87ac05b) for testing. Also move pnpm.overrides and pnpm.peerDependencyRules from package.json into pnpm-workspace.yaml (pnpm 11 no longer reads the package.json field), and set blockExoticSubdeps: false so URL-resolved overrides are permitted in subdependencies.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependencies to use specific preview builds of vite-plus and vitest from pkg.pr.new, along with upgrading oxfmt and oxlint packages. Two configuration issues were identified in pnpm-workspace.yaml: first, the blockExoticSubdeps option is an .npmrc setting and is not supported as a top-level field in the workspace configuration; second, the minimumReleaseAgeExclude list should only contain package names without version suffixes (e.g., @0.52.0 or @1.67.0) for pnpm to match them correctly.
| - '@oxlint/binding-win32-x64-msvc@1.67.0' | ||
| - oxfmt@0.52.0 | ||
| - oxlint@1.67.0 | ||
| blockExoticSubdeps: false |
There was a problem hiding this comment.
The blockExoticSubdeps setting is an .npmrc configuration option (block-exotic-subdeps=false) and is not supported or recognized as a top-level field in pnpm-workspace.yaml. To allow URL-resolved overrides in subdependencies, you should define block-exotic-subdeps=false in your .npmrc file instead.
# block-exotic-subdeps=false should be set in .npmrc instead| - '@oxfmt/binding-android-arm-eabi@0.52.0' | ||
| - '@oxfmt/binding-android-arm64@0.52.0' | ||
| - '@oxfmt/binding-darwin-arm64@0.52.0' | ||
| - '@oxfmt/binding-darwin-x64@0.52.0' | ||
| - '@oxfmt/binding-freebsd-x64@0.52.0' | ||
| - '@oxfmt/binding-linux-arm-gnueabihf@0.52.0' | ||
| - '@oxfmt/binding-linux-arm-musleabihf@0.52.0' | ||
| - '@oxfmt/binding-linux-arm64-gnu@0.52.0' | ||
| - '@oxfmt/binding-linux-arm64-musl@0.52.0' | ||
| - '@oxfmt/binding-linux-ppc64-gnu@0.52.0' | ||
| - '@oxfmt/binding-linux-riscv64-gnu@0.52.0' | ||
| - '@oxfmt/binding-linux-riscv64-musl@0.52.0' | ||
| - '@oxfmt/binding-linux-s390x-gnu@0.52.0' | ||
| - '@oxfmt/binding-linux-x64-gnu@0.52.0' | ||
| - '@oxfmt/binding-linux-x64-musl@0.52.0' | ||
| - '@oxfmt/binding-openharmony-arm64@0.52.0' | ||
| - '@oxfmt/binding-win32-arm64-msvc@0.52.0' | ||
| - '@oxfmt/binding-win32-ia32-msvc@0.52.0' | ||
| - '@oxfmt/binding-win32-x64-msvc@0.52.0' | ||
| - '@oxlint/binding-android-arm-eabi@1.67.0' | ||
| - '@oxlint/binding-android-arm64@1.67.0' | ||
| - '@oxlint/binding-darwin-arm64@1.67.0' | ||
| - '@oxlint/binding-darwin-x64@1.67.0' | ||
| - '@oxlint/binding-freebsd-x64@1.67.0' | ||
| - '@oxlint/binding-linux-arm-gnueabihf@1.67.0' | ||
| - '@oxlint/binding-linux-arm-musleabihf@1.67.0' | ||
| - '@oxlint/binding-linux-arm64-gnu@1.67.0' | ||
| - '@oxlint/binding-linux-arm64-musl@1.67.0' | ||
| - '@oxlint/binding-linux-ppc64-gnu@1.67.0' | ||
| - '@oxlint/binding-linux-riscv64-gnu@1.67.0' | ||
| - '@oxlint/binding-linux-riscv64-musl@1.67.0' | ||
| - '@oxlint/binding-linux-s390x-gnu@1.67.0' | ||
| - '@oxlint/binding-linux-x64-gnu@1.67.0' | ||
| - '@oxlint/binding-linux-x64-musl@1.67.0' | ||
| - '@oxlint/binding-openharmony-arm64@1.67.0' | ||
| - '@oxlint/binding-win32-arm64-msvc@1.67.0' | ||
| - '@oxlint/binding-win32-ia32-msvc@1.67.0' | ||
| - '@oxlint/binding-win32-x64-msvc@1.67.0' | ||
| - oxfmt@0.52.0 | ||
| - oxlint@1.67.0 |
There was a problem hiding this comment.
The minimumReleaseAgeExclude list expects exact package names (e.g., @oxfmt/binding-android-arm-eabi or oxfmt). Appending version suffixes like @0.52.0 or @1.67.0 will prevent pnpm from matching the package names correctly, meaning the minimum release age check will still apply to these packages. Please remove the version suffixes from the package names.
- '@oxfmt/binding-android-arm-eabi'
- '@oxfmt/binding-android-arm64'
- '@oxfmt/binding-darwin-arm64'
- '@oxfmt/binding-darwin-x64'
- '@oxfmt/binding-freebsd-x64'
- '@oxfmt/binding-linux-arm-gnueabihf'
- '@oxfmt/binding-linux-arm-musleabihf'
- '@oxfmt/binding-linux-arm64-gnu'
- '@oxfmt/binding-linux-arm64-musl'
- '@oxfmt/binding-linux-ppc64-gnu'
- '@oxfmt/binding-linux-riscv64-gnu'
- '@oxfmt/binding-linux-riscv64-musl'
- '@oxfmt/binding-linux-s390x-gnu'
- '@oxfmt/binding-linux-x64-gnu'
- '@oxfmt/binding-linux-x64-musl'
- '@oxfmt/binding-openharmony-arm64'
- '@oxfmt/binding-win32-arm64-msvc'
- '@oxfmt/binding-win32-ia32-msvc'
- '@oxfmt/binding-win32-x64-msvc'
- '@oxlint/binding-android-arm-eabi'
- '@oxlint/binding-android-arm64'
- '@oxlint/binding-darwin-arm64'
- '@oxlint/binding-darwin-x64'
- '@oxlint/binding-freebsd-x64'
- '@oxlint/binding-linux-arm-gnueabihf'
- '@oxlint/binding-linux-arm-musleabihf'
- '@oxlint/binding-linux-arm64-gnu'
- '@oxlint/binding-linux-arm64-musl'
- '@oxlint/binding-linux-ppc64-gnu'
- '@oxlint/binding-linux-riscv64-gnu'
- '@oxlint/binding-linux-riscv64-musl'
- '@oxlint/binding-linux-s390x-gnu'
- '@oxlint/binding-linux-x64-gnu'
- '@oxlint/binding-linux-x64-musl'
- '@oxlint/binding-openharmony-arm64'
- '@oxlint/binding-win32-arm64-msvc'
- '@oxlint/binding-win32-ia32-msvc'
- '@oxlint/binding-win32-x64-msvc'
- oxfmt
- oxlint
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #789 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 10 10
Lines 730 730
Branches 228 228
=======================================
Hits 691 691
Misses 36 36
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
Summary
vite-plus,@voidzero-dev/vite-plus-core, and@voidzero-dev/vite-plus-testat the pkg.pr.new build from voidzero-dev/vite-plus#1693 (commit87ac05b) for smoke testing.pnpm.overridesandpnpm.peerDependencyRulesout ofpackage.jsonand intopnpm-workspace.yaml(pnpm 11 no longer reads thepnpmfield inpackage.json).blockExoticSubdeps: falseinpnpm-workspace.yamlso URL-resolved overrides are permitted in subdependencies.Test plan
vp installresolves the pkg.pr.new tarballs (commit87ac05b) for vite-plus, vite-plus-core, vite-plus-testvp check— formatting, lint, and typecheck cleanvp test run— 208 passed / 6 skipped across 40 test files