Change to emit end and close immediately at EOF during download#259
Open
std4lqi wants to merge 2 commits into
Open
Change to emit end and close immediately at EOF during download#259std4lqi wants to merge 2 commits into
end and close immediately at EOF during download#259std4lqi wants to merge 2 commits into
Conversation
Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
Author
|
It's to fix #228 actually. |
Signed-off-by: Qi Liang <liangqi@cn.ibm.com>
|
I have also run into a similar issue on Node 11 and 12, and can confirm this PR fixes it. Thanks @std4lqi! |
|
See #277 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Qi Liang liangqi@cn.ibm.com
Change to emit
endandcloseat EOF immediately during download, without waiting for 226 or 250 for RETR. This could close the stream quickly, instead of hanging for 1 or 2 minutes on Node.JS v10 and v12.