proper UTF-8 handling

[AyrA]

This code properly handles UTF-8 server responses and prevents double encoding.

[mscdex]

I still prefer to check and only use utf8 if the server explicitly supports it. A slightly better way to handle the encoding might be to just do source.setEncoding('binary') or source.setEncoding('utf8') depending on the server. That way data events always get properly formed strings.

[sitexw]

I agree with you (@mscdex) and @AyrA. But for now, nothing happens ...
I think it would be good to implement the code of @AyrA and add a variable "encoding" the options that allows you to manually set the encoding with a default value of "binary", not to break compatibility with an older application.

It would be really nice if it could be done quickly because for myself, I have to manually edit the package ... Thank you.

[hdjarv]

Hi, I'm really interested in proper UTF-8 support for this great node module. Any news wether this PR (#123 as well?) is going to be merged into master?

[mscdex]

I've decided to go about this slightly differently in ebb0fab, which should be more efficient.

Can you please test the master branch and let me know if that works for you all?

[hdjarv]

I've tested current master (ebb0fab) and it works fine for me.

[AntonBryansky]

@AyrA
What's about changing in parser lib? There used "buffer += chunk.toString("binary")" construction. May be it'll help.

[bachvtuan]

Hi everyone. how are thing going now ?
I see this issue isn't fixed for a long time.

[lerit]

it work for me ,resolve my problem,can you merge it to master?
@mscdex

[actiontwo]

Yeah, It work with me to, but no one merge to master