From 1ce040b837a3d766b7c53517f3e4e270734e3f58 Mon Sep 17 00:00:00 2001 From: avinash Date: Wed, 29 Mar 2023 18:11:17 +0530 Subject: [PATCH] get_bugbug_labels no longer adds nobug type to regression training data --- bugbug/models/defect.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bugbug/models/defect.py b/bugbug/models/defect.py index 6b69a58fc6..5776ae111e 100644 --- a/bugbug/models/defect.py +++ b/bugbug/models/defect.py @@ -98,9 +98,9 @@ def get_bugbug_labels(self, kind="bug") -> dict[int, Any]: assert category in ["True", "False"], f"unexpected category {category}" if kind == "bug": classes[int(bug_id)] = 1 if category == "True" else 0 + # do not include nobug in regression classifier training data elif kind == "regression": - if category == "False": - classes[int(bug_id)] = 0 + continue elif kind == "defect_enhancement_task": if category == "True": classes[int(bug_id)] = "defect" @@ -115,9 +115,9 @@ def get_bugbug_labels(self, kind="bug") -> dict[int, Any]: if kind == "bug": classes[int(bug_id)] = 1 if category != "nobug" else 0 elif kind == "regression": - if category == "bug_unknown_regression": + # regression classifier to classify between regression and bug_no_regression only + if category == "bug_unknown_regression" or category == "nobug": continue - classes[int(bug_id)] = 1 if category == "regression" else 0 elif kind == "defect_enhancement_task": if category != "nobug":