openid login does not work for openid accounts without e-mail

[asaladin]

some openid providers don't send user email along with authentication credentials.
This can lead to an internal server error since the velruse endpoint try to read an e-mail.

[osallou]

Mobyle will expect to have email. Velruse should ask to get it, but if provider (or user) does not provide it, authentication is expected to fail.

This should not raise an internal error however.
login_complete_view should in this case test the value (not None) and route to authentication failure HTTP.

If it fails in Velruse, we should try to fix it and ask for a pull request.

[asaladin]

It's our code that fails with the internal error.

If we also provide a classic "login/password" way to register maybe we can reuse the same logic to ask for a valid e-mail for openid providers that don't pass an email ?

[osallou]

Something like:

.....
openid authentication is ok
....
If email is None:
    if user[email] is not None:
        route to authenticated
    else:
    route to a page asking for an email
    then send email and wait for mail confirmation
    at email confirmation create user and store email