fix warnings

Author: ianardee

pom.xml

@@ -90,8 +90,8 @@
                 <version>${org.projectlombok.lombok-mapstruct-binding.version}</version>
               </path>
             </annotationProcessorPaths>
-            <source>11</source>
-            <target>11</target>
+            <source>${compiler.source}</source>
+            <target>${compiler.target}</target>
           </configuration>
         </plugin>
           <plugin>
@@ -102,7 +102,7 @@
               <linkXRef>false</linkXRef>
               <printFailingErrors>true</printFailingErrors>
               <failurePriority>3</failurePriority>
-              <targetJdk>11</targetJdk>
+              <targetJdk>${compiler.target}</targetJdk>
             </configuration>
           </plugin>
         <plugin>
@@ -129,8 +129,8 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
         <configuration>
-          <source>${maven.compiler.source}</source>
-          <target>${maven.compiler.target}</target>
+          <source>${compiler.source}</source>
+          <target>${compiler.target}</target>
         </configuration>
       </plugin>
       <plugin>
@@ -340,12 +340,6 @@
       <scope>test</scope>
       <version>${org.junit.jupiter.version}</version>
     </dependency>
-    <dependency>
-      <artifactId>junit-platform-suite</artifactId>
-      <groupId>org.junit.platform</groupId>
-      <scope>test</scope>
-      <version>${org.junit.platform.version}</version>
-    </dependency>
     <dependency>
       <artifactId>junit-pioneer</artifactId>
       <groupId>org.junit-pioneer</groupId>
@@ -393,8 +387,8 @@
     </surefire.addOpens>
 
     <!-- Minimum Java version -->
-    <maven.compiler.source>11</maven.compiler.source>
-    <maven.compiler.target>11</maven.compiler.target>
+    <compiler.source>11</compiler.source>
+    <compiler.target>11</compiler.target>
 
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 
@@ -409,7 +403,7 @@
     <org.apache.pdfbox.version>3.0.7</org.apache.pdfbox.version>
     <org.mapstruct.version>1.5.3.Final</org.mapstruct.version>
     <org.projectlombok.lombok-mapstruct-binding.version>0.2.0</org.projectlombok.lombok-mapstruct-binding.version>
-    <org.projectlombok.version>1.18.38</org.projectlombok.version>
+    <org.projectlombok.version>1.18.40</org.projectlombok.version>
     <org.slf4j.version>2.0.17</org.slf4j.version>
 
     <!-- Build/Test dependencies -->
@@ -424,10 +418,10 @@
     <org.apache.maven.project.info.reports.version>3.0.0</org.apache.maven.project.info.reports.version>
     <org.apache.maven.site.version>3.7.1</org.apache.maven.site.version>
     <org.apache.maven.surfire.version>3.5.5</org.apache.maven.surfire.version>
-    <org.junit.jupiter.version>5.8.2</org.junit.jupiter.version>
-    <org.junit.pioneer.version>1.9.1</org.junit.pioneer.version>
-    <org.junit.platform.version>1.9.2</org.junit.platform.version>
     <wiremock.version>3.13.2</wiremock.version>
+    <!-- jupiter version 5.x is the last with JRE 11 support -->
+    <org.junit.jupiter.version>5.11.4</org.junit.jupiter.version>
+    <org.junit.pioneer.version>2.3.0</org.junit.pioneer.version>
   </properties>
 
 </project>

src/main/java/com/mindee/v1/parsing/LocalResponse.java

@@ -62,6 +62,7 @@ private <P extends Inference, R> R deserialize(
   public <T extends Inference> AsyncPredictResponse<T> deserializeAsyncResponse(
       Class<T> productClass
   ) throws IOException {
+    @SuppressWarnings("unchecked")
     AsyncPredictResponse<T> response = deserialize(AsyncPredictResponse.class, productClass);
     response.setRawResponse(new String(this.file, StandardCharsets.UTF_8));
     return response;
@@ -78,6 +79,7 @@ public <T extends Inference> AsyncPredictResponse<T> deserializeAsyncResponse(
   public <T extends Inference> PredictResponse<T> deserializeSyncResponse(
       Class<T> productClass
   ) throws IOException {
+    @SuppressWarnings("unchecked")
     PredictResponse<T> response = deserialize(PredictResponse.class, productClass);
     response.setRawResponse(new String(this.file, StandardCharsets.UTF_8));
     return response;

src/main/java/com/mindee/v1/parsing/generated/GeneratedObject.java

@@ -36,7 +36,7 @@ public StringField asStringField() {
    * @return An {@link AmountField} containing a double value.
    */
   public AmountField asAmountField() {
-    Double value;
+    double value;
     Object rawValue = this.get("value");
     if (rawValue instanceof Integer) {
       value = ((Integer) rawValue).doubleValue();
@@ -109,13 +109,13 @@ public Polygon getAsPolygon(String key) {
     if (!this.containsKey(key)) {
       return null;
     }
-    Object rawPolygon = this.get(key);
+    var rawPolygon = this.get(key);
     // a valid polygon must have at least 4 points
     if (!(rawPolygon instanceof List && ((List<?>) rawPolygon).size() >= 4)) {
       return null;
     }
     // a valid point must have exactly 2 coordinates
-    for (Object point : (List<?>) rawPolygon) {
+    for (var point : (List<?>) rawPolygon) {
       if (!(point instanceof List) || ((List<?>) point).size() != 2) {
         return null;
       }
@@ -125,7 +125,9 @@ public Polygon getAsPolygon(String key) {
         }
       }
     }
-    return new Polygon((List<List<Double>>) rawPolygon);
+    @SuppressWarnings("unchecked")
+    List<List<Double>> points = (List<List<Double>>) rawPolygon;
+    return new Polygon(points);
   }
 
   /**

src/main/java/com/mindee/v1/parsing/generated/GeneratedV1PredictionDeserializer.java

@@ -3,14 +3,11 @@
 import com.fasterxml.jackson.core.JsonParser;
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.mindee.v1.product.generated.GeneratedV1Document;
 import java.io.IOException;
 import java.util.HashMap;
-import java.util.Iterator;
-import java.util.Map;
 
 /**
  * JSON deserializer for generated documents v1.x.
@@ -21,8 +18,6 @@ public GeneratedV1PredictionDeserializer(Class<?> vc) {
     super(vc);
   }
 
-  private static final ObjectMapper mapper = new ObjectMapper();
-
   public GeneratedV1PredictionDeserializer() {
     this(null);
   }
@@ -32,15 +27,14 @@ public GeneratedV1Document deserialize(
       JsonParser jsonParser,
       DeserializationContext deserializationContext
   ) throws IOException {
-    ObjectNode rootNode = jsonParser.getCodec().readTree(jsonParser);
-    Map<String, GeneratedFeature> features = new HashMap<>();
+    var mapper = jsonParser.getCodec();
+    ObjectNode rootNode = mapper.readTree(jsonParser);
+    var features = new HashMap<String, GeneratedFeature>();
 
-    for (Iterator<Map.Entry<String, JsonNode>> subNode = rootNode.fields(); subNode.hasNext();) {
-      Map.Entry<String, JsonNode> featureNode = subNode.next();
+    for (var featureNode : rootNode.properties()) {
       String featureName = featureNode.getKey();
 
       GeneratedFeature feature;
-
       if (featureNode.getValue().isArray()) {
         feature = new GeneratedFeature(true);
         for (JsonNode item : featureNode.getValue()) {

src/main/java/com/mindee/v2/parsing/inference/field/DynamicField.java

@@ -82,13 +82,13 @@ public ObjectField getObjectField() throws IllegalStateException {
    */
   public <T extends BaseField> T getField(Class<T> type) throws IllegalArgumentException {
     if (type == SimpleField.class) {
-      return (T) this.getSimpleField();
+      return type.cast(this.getSimpleField());
     }
     if (type == ListField.class) {
-      return (T) this.getListField();
+      return type.cast(this.getListField());
     }
     if (type == ObjectField.class) {
-      return (T) this.getObjectField();
+      return type.cast(this.getObjectField());
     }
     throw new IllegalArgumentException("Cannot cast to " + type.getSimpleName());
   }