Remove retired CommunityToolkit.WinAppSDK.LottieWinRT package from DrawingIsland#645
Open
qiutongMS wants to merge 1 commit into
Open
Remove retired CommunityToolkit.WinAppSDK.LottieWinRT package from DrawingIsland#645qiutongMS wants to merge 1 commit into
qiutongMS wants to merge 1 commit into
Conversation
The CommunityToolkit.WinAppSDK.LottieWinRT package has been retired and is no longer available on nuget.org (the package page and the v3-flatcontainer index both return 404). Any clean nuget restore of DrawingCsTestApp therefore failed. The Lottie code path in this sample is not active — the call site in Program.cs (var lottie = LottieIslandScenario.CreateLottieIsland(...)) was already commented out — so removing the dependency has no runtime effect. Cleanup: * Delete LottieIslandScenario.cs and the unused Assets/LottieLogo1.json asset so the sample no longer references the retired package at all. * Remove the CommunityToolkit.WinAppSDK.LottieWinRT and CommunityToolkit.WinUI.Lottie <PackageReference>s from DrawingCsTestApp.csproj and their <PackageVersion>s from the repository-level Samples/Directory.Packages.props. * Add Microsoft.Graphics.Win2D as a direct <PackageReference>. It used to come in transitively via the Lottie package and is still needed by HelmetScenario.cs and SceneNodeCommon.cs (which use Microsoft.Graphics.Canvas types). The package version is already declared centrally in Samples/Directory.Packages.props. * Remove the dead commented-out Lottie call site and its #region wrapper from Program.cs, and the <Content Update> entry for LottieLogo1.json from the csproj. Verified: msbuild DrawingCsTestApp.csproj -p:Configuration=Debug -p:Platform=x64 produces a clean restore and build (0 warnings, 0 errors). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the DrawingIsland sample’s dependency graph by removing references to the retired CommunityToolkit.*.Lottie* packages (now removed from nuget.org), eliminating restore failures for fresh clones while preserving the sample’s buildability by explicitly referencing Win2D.
Changes:
- Removed central package version entries and project package references for the retired Lottie packages.
- Added an explicit
Microsoft.Graphics.Win2Dpackage reference to keepMicrosoft.Graphics.Canvasusages building. - Removed dead, already-disabled Lottie scenario code and deleted the unused Lottie scenario file + asset.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Samples/Directory.Packages.props | Removes retired Lottie package version entries from central package management. |
| Samples/Islands/DrawingIsland/DrawingCsTestApp/DrawingCsTestApp.csproj | Drops Lottie package refs, adds explicit Win2D dependency, removes now-unused content item. |
| Samples/Islands/DrawingIsland/DrawingCsTestApp/Program.cs | Deletes dead commented-out Lottie scenario wiring. |
| Samples/Islands/DrawingIsland/DrawingCsTestApp/LottieIslandScenario.cs | Removes the Lottie scenario implementation that depended on retired packages. |
| Samples/Islands/DrawingIsland/DrawingCsTestApp/Assets/LottieLogo1.json | Deletes the unused Lottie JSON asset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the retired
CommunityToolkit.WinAppSDK.LottieWinRT(and its siblingCommunityToolkit.WinUI.Lottie) NuGet packages from the DrawingIsland sample.Both packages are removed from nuget.org (not just unlisted):
https://www.nuget.org/packages/CommunityToolkit.WinAppSDK.LottieWinRT→ 404https://api.nuget.org/v3-flatcontainer/communitytoolkit.winappsdk.lottiewinrt/index.json→ 404This silently breaks
dotnet restorefor new clones. The only caller in this repo (LottieIslandScenario) was already commented out inProgram.cs, so the practical change is build-system cleanup.Changes
Samples/Directory.Packages.props— remove both<PackageVersion>entries.Samples/Islands/DrawingIsland/DrawingCsTestApp/DrawingCsTestApp.csproj<PackageReference>entries.<PackageReference Include="Microsoft.Graphics.Win2D" />. This is required:HelmetScenario.csandSceneNodeCommon.csstillusing Microsoft.Graphics.Canvas, which was previously being pulled in transitively through Lottie. Version comes from central package management.<Content Update="Assets\LottieLogo1.json" />block.Samples/Islands/DrawingIsland/DrawingCsTestApp/Program.cs— delete the dead//var lottie = new LottieIslandScenario(...)lines and their#regionwrapper.Samples/Islands/DrawingIsland/DrawingCsTestApp/LottieIslandScenario.cs.Samples/Islands/DrawingIsland/DrawingCsTestApp/Assets/LottieLogo1.json(~190 KB asset).Verification
msbuild DrawingCsTestPackage\DrawingCsTestPackage.wapproj /p:Configuration=Debug /p:Platform=x64→ 0 errors, 0 warnings.winapp run; main windowDrawing C# .NET TestAppopens. No scenarios are removed (the only scenario removed is the one that was already disabled).Microsoft.Graphics.Canvas.dllcorrectly deploys underruntimes/win-x64/native/.Target Release
N/A — dependency cleanup, no API or behavior change.
Checklist
winapp run).Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com