diff --git a/gui-js/apps/minsky-electron/src/app/managers/CommandsManager.ts b/gui-js/apps/minsky-electron/src/app/managers/CommandsManager.ts index fb2044549..ca541008d 100644 --- a/gui-js/apps/minsky-electron/src/app/managers/CommandsManager.ts +++ b/gui-js/apps/minsky-electron/src/app/managers/CommandsManager.ts @@ -1235,12 +1235,11 @@ export class CommandsManager { static async applyPreferences() { const { enableMultipleEquityColumns, - godleyTableShowValues, godleyTableOutputStyle, font, numBackups, } = StoreManager.store.get('preferences'); - minsky.setGodleyDisplayValue(godleyTableShowValues,godleyTableOutputStyle); + minsky.displayStyle(godleyTableOutputStyle); minsky.multipleEquities(enableMultipleEquityColumns); minsky.defaultFont(font); minsky.numBackups(numBackups); diff --git a/gui-js/apps/minsky-electron/src/app/managers/ContextMenuManager.ts b/gui-js/apps/minsky-electron/src/app/managers/ContextMenuManager.ts index 1444cc0df..8750ed666 100644 --- a/gui-js/apps/minsky-electron/src/app/managers/ContextMenuManager.ts +++ b/gui-js/apps/minsky-electron/src/app/managers/ContextMenuManager.ts @@ -682,7 +682,19 @@ export class ContextMenuManager { label: 'Display variables', type: 'checkbox', checked: displayVariableChecked, - click: () => godley.toggleVariableDisplay() + click: async () => { + await godley.toggleVariableDisplay(); + await minsky.canvas.requestRedraw(); + } + }), + new MenuItem({ + label: 'Display values', + type: 'checkbox', + checked: await godley.displayValues(), + click: async () => { + await godley.toggleDisplayValues(); + await minsky.canvas.requestRedraw(); + }, }), new MenuItem({ label: 'Copy flow variables', diff --git a/gui-js/apps/minsky-electron/src/app/managers/GodleyMenuManager.ts b/gui-js/apps/minsky-electron/src/app/managers/GodleyMenuManager.ts index 732d6b944..c837ce598 100644 --- a/gui-js/apps/minsky-electron/src/app/managers/GodleyMenuManager.ts +++ b/gui-js/apps/minsky-electron/src/app/managers/GodleyMenuManager.ts @@ -58,7 +58,6 @@ export class GodleyMenuManager { const preferences = StoreManager.store.get('preferences'); let { enableMultipleEquityColumns, - godleyTableShowValues, godleyTableOutputStyle, } = preferences; @@ -66,19 +65,14 @@ export class GodleyMenuManager { enableMultipleEquityColumns = value as boolean; minsky.multipleEquities(enableMultipleEquityColumns); GodleyMenuManager.refresh(window); - } else { - if (property === 'godleyTableOutputStyle') { + } else if (property === 'godleyTableOutputStyle') { godleyTableOutputStyle = value as GodleyTableOutputStyles; - } else if (property === 'godleyTableShowValues') { - godleyTableShowValues = value as boolean; - } - minsky.setGodleyDisplayValue(godleyTableShowValues, godleyTableOutputStyle); + minsky.displayStyle(godleyTableOutputStyle); } StoreManager.store.set({ preferences: { ...preferences, - godleyTableShowValues: godleyTableShowValues, godleyTableOutputStyle: godleyTableOutputStyle, enableMultipleEquityColumns: enableMultipleEquityColumns, }, diff --git a/gui-js/apps/minsky-electron/src/app/managers/StoreManager.ts b/gui-js/apps/minsky-electron/src/app/managers/StoreManager.ts index ddcc18df3..f3aa3baec 100644 --- a/gui-js/apps/minsky-electron/src/app/managers/StoreManager.ts +++ b/gui-js/apps/minsky-electron/src/app/managers/StoreManager.ts @@ -3,7 +3,6 @@ import Store from 'electron-store'; import {homedir} from 'node:os'; interface MinskyPreferences { - godleyTableShowValues: boolean; godleyTableOutputStyle: string; enableMultipleEquityColumns: boolean; numberOfRecentFilesToDisplay: number; @@ -31,7 +30,6 @@ class StoreManager { defaultModelDirectory: homedir(), defaultDataDirectory: homedir(), preferences: { - godleyTableShowValues: false, godleyTableOutputStyle: 'sign', enableMultipleEquityColumns: false, numberOfRecentFilesToDisplay: 10, diff --git a/gui-js/libs/menu/src/lib/options/preferences/preferences.component.html b/gui-js/libs/menu/src/lib/options/preferences/preferences.component.html index 0474daaee..42d75235e 100644 --- a/gui-js/libs/menu/src/lib/options/preferences/preferences.component.html +++ b/gui-js/libs/menu/src/lib/options/preferences/preferences.component.html @@ -3,17 +3,6 @@