Hi folks!
It is rather post-mortem than a feature request.
I tried to set up the tool for Bitbucket Server and found that it does not work.
First of all, the method pr_diff does not exist leading to a runtime error.
Secondly, I tried to extend the DangerfileBitbucketServerPlugin and add the pr_diff method, but I found that Bitbucket Server REST API does not support it. In fact, there is a method for that, but it does not return the raw diff. See the example here.
I think it is possible to get it done, but it would require extending the DangerfileBitbucketServerPlugin with pr_diff method and also parsing that JSON format into something consumable by this tool. But I am not sure if it worth the effort for me, so I am leaving this here as a reference to potential future implementors. 😺
Cheers, and keep up the great work!
Hi folks!
It is rather post-mortem than a feature request.
I tried to set up the tool for Bitbucket Server and found that it does not work.
First of all, the method
pr_diffdoes not exist leading to a runtime error.Secondly, I tried to extend the
DangerfileBitbucketServerPluginand add thepr_diffmethod, but I found that Bitbucket Server REST API does not support it. In fact, there is a method for that, but it does not return the raw diff. See the example here.I think it is possible to get it done, but it would require extending the
DangerfileBitbucketServerPluginwithpr_diffmethod and also parsing that JSON format into something consumable by this tool. But I am not sure if it worth the effort for me, so I am leaving this here as a reference to potential future implementors. 😺Cheers, and keep up the great work!