scripts/build: set grpcnotrace build-tag to reduce binary size#7002
Merged
Conversation
Reduces the binary size (39810466 - 39289106 => 521360 (521 kb) We only import google.golang.org/grpc as an indirect dependency, and do not make gRPC connections. grpcnotrace avoids importing golang.org/x/net/trace, which in turn enables dead code elimination, which can yield 10-15% improvements in binary size when tracing is not needed. see https://github.com/grpc/grpc-go/blob/v1.81.1/trace_notrace.go#L23-L25 Before: ls -l ./build/docker-darwin-arm64 -rwxr-xr-x 1 thajeztah staff 39810466 May 22 11:44 ./build/docker-darwin-arm64* ls -lh ./build/docker-darwin-arm64 -rwxr-xr-x 1 thajeztah staff 38M May 22 11:44 ./build/docker-darwin-arm64* After: ls -l ./build/docker-darwin-arm64 -rwxr-xr-x 1 thajeztah staff 39289106 May 22 11:45 ./build/docker-darwin-arm64* ls -lh ./build/docker-darwin-arm64 -rwxr-xr-x 1 thajeztah staff 37M May 22 11:45 ./build/docker-darwin-arm64* Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vvoland
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces the binary size (39810466 - 39289106 => 521360 (521 kb)
We only import google.golang.org/grpc as an indirect dependency, and do not make gRPC connections.
grpcnotrace avoids importing golang.org/x/net/trace, which in turn enables dead code elimination, which can yield 10-15% improvements in binary size when tracing is not needed.
see https://github.com/grpc/grpc-go/blob/v1.81.1/trace_notrace.go#L23-L25
Before:
After:
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)