Skip to content

Update CLI reference docs for v2.3.0#1097

Open
adamwg wants to merge 2 commits into
crossplane:masterfrom
adamwg:awg/cli-reference-v2.3.0
Open

Update CLI reference docs for v2.3.0#1097
adamwg wants to merge 2 commits into
crossplane:masterfrom
adamwg:awg/cli-reference-v2.3.0

Conversation

@adamwg
Copy link
Copy Markdown
Member

@adamwg adamwg commented May 21, 2026

Use the new crossplane generate-docs command to generate CLI reference docs from the built-in CLI help. Update both master and v2.3, since they're the same for now.

Toward #1092

Use the new `crossplane generate-docs` command to generate CLI reference docs
from the built-in CLI help. Update both `master` and `v2.3`, since they're the
same for now.

Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
@netlify
Copy link
Copy Markdown

netlify Bot commented May 21, 2026

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit db4761f
🔍 Latest deploy log https://app.netlify.com/projects/crossplane/deploys/6a10e3476d227400080b2a14
😎 Deploy Preview https://deploy-preview-1097--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🟢 up 2 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a couple funny headings that are rendering odd, e.g. https://deploy-preview-1097--crossplane.netlify.app/v2.3/cli/command-reference/#read-the-xrd-from-stdin

are those at the right level? are they supposed to be headings? 🤔

@adamwg
Copy link
Copy Markdown
Member Author

adamwg commented May 21, 2026

there are a couple funny headings that are rendering odd, e.g. https://deploy-preview-1097--crossplane.netlify.app/v2.3/cli/command-reference/#read-the-xrd-from-stdin

are those at the right level? are they supposed to be headings? 🤔

Good catch - we missed properly converting the help for crossplane xrd convert to markdown, so it's producing some weird rendering. For now, I think I'll manually edit the generated docs to fix this and the vale warnings, then propagate the changes back to the CLI's built-in help that powers the generation.

I've updated the CLI's docs generator locally to fix as many vale issues as
possible and re-generated the docs using it. There are still a few issues we
can't fix because of how our docs generation works:

- The abbreviation `config` in the `crossplane config` command.
- The abbreviation `k8s` in the flag help for `crossplane dependency add`.
- The abbreviation `admin` in `cluster-admin` in the help for `crossplane
  project run`.

Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
@adamwg
Copy link
Copy Markdown
Member Author

adamwg commented May 22, 2026

I've fixed as many vale issues as possible while still auto-generating docs. See crossplane/cli#30 for details.

@jbw976
Copy link
Copy Markdown
Member

jbw976 commented May 23, 2026

amazing @adamwg, great work at tackling most all of the vale issues!

do you think it would be possible (or reasonable) to include exclusions in the CLI docs templates where needed for the specifically failing Vale styles, e.g. gitlab.SubstitutionWarning, gitlab.Units, Google.WordList, etc.? or is that just not a path we think is worth it? if it's not worth it (or not possible), do we live with the remaining failures? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants