Fix #14863 (dumpfile: flag isSimplifiedScope when compound scope is missing)

Author: danmar

lib/token.h

@@ -1498,7 +1498,7 @@ class CPPCHECKLIB Token {
         fIsImplicitInt          = (1ULL << 33), // Is "int" token implicitly added?
         fIsInline               = (1ULL << 34), // Is this a inline type
         fIsTemplate             = (1ULL << 35),
-        fIsSimplifedScope       = (1ULL << 36), // scope added when simplifying e.g. if (int i = ...; ...)
+        fIsSimplifedScope       = (1ULL << 36), // scope added when simplifying e.g. if (x) f(); => if (x) { f(); }
         fIsRemovedVoidParameter = (1ULL << 37), // A void function parameter has been removed
         fIsIncompleteConstant   = (1ULL << 38),
         fIsRestrict             = (1ULL << 39), // Is this a restrict pointer type

lib/tokenize.cpp

@@ -6218,6 +6218,8 @@ void Tokenizer::dump(std::ostream &out) const
         }
         if (tok->isRemovedVoidParameter())
             outs += " isRemovedVoidParameter=\"true\"";
+        if (tok->isSimplifiedScope())
+            outs += " isSimplifiedScope=\"true\"";
         if (tok->isSplittedVarDeclComma())
             outs += " isSplittedVarDeclComma=\"true\"";
         if (tok->isSplittedVarDeclEq())
@@ -7004,10 +7006,12 @@ Token *Tokenizer::simplifyAddBracesPair(Token *tok, bool commandWithCondition)
         tokAfterCondition->previous()->insertToken("{");
         Token * tokOpenBrace=tokAfterCondition->previous();
         tokOpenBrace->column(tokAfterCondition->column());
+        tokOpenBrace->isSimplifiedScope(true);
 
         tokEnd->insertToken("}");
         Token * tokCloseBrace=tokEnd->next();
         tokCloseBrace->column(tokEnd->column());
+        tokCloseBrace->isSimplifiedScope(true);
 
         Token::createMutualLinks(tokOpenBrace,tokCloseBrace);
         tokBracesEnd=tokCloseBrace;

test/testtokenize.cpp

@@ -140,6 +140,7 @@ class TestTokenizer : public TestFixture {
 
         TEST_CASE(whileAddBraces);
         TEST_CASE(whileAddBracesLabels);
+        TEST_CASE(whileAddBracesDump);
 
         TEST_CASE(doWhileAddBraces);
         TEST_CASE(doWhileAddBracesLabels);
@@ -1532,6 +1533,17 @@ class TestTokenizer : public TestFixture {
         ASSERT_EQUALS("", filter_valueflow(errout_str()));
     }
 
+    void whileAddBracesDump() {
+        const char code[] = "void f(){while(a);}";
+        SimpleTokenizer tokenizer(settingsDefault, *this, false);
+        ASSERT(tokenizer.tokenize(code));
+        ASSERT(Token::simpleMatch(tokenizer.tokens(), "void f ( ) { while ( a ) { ; } }"));
+        std::ostringstream ostr;
+        tokenizer.dump(ostr);
+        const std::string dump = ostr.str();
+        ASSERT(dump.find("isSimplifiedScope=\"true\"") != std::string::npos);
+    }
+
     void doWhileAddBraces() {
         {
             const char code[] = "{do ; while (0);}";