Skip to content

The 'Main Branch Enforce PRs' ruleset is disabled, so PRs can merge while require-all-checks-to-pass is failing #12984

Description

@kobihikri

Hi — I noticed the repo already has a ruleset that would enforce PR checks on main, but it's switched off.

Main Branch Enforce PRs (id 6233045) is set to enforcement: disabled, and it declares exactly what you'd want:

required_approving_review_count: 1
required_status_checks: ["require-all-checks-to-pass", "CLAAssistant"]

Because it's disabled, PRs can land while that check is red. The clearest example is the current main HEAD itself — d0a3c0b6 is the merge commit of #12816:

  • require-all-checks-to-pass completed as failure at 00:21:31
  • the PR merged at 00:21:52 — 21 seconds later
  • no approving review

I'm not suggesting a new policy; the policy is already written and correctly targeted. It just needs enforcement flipped to active. (Main Branch Baseline Restrictions, id 6232937, is disabled too.)

I may be missing a reason it was turned off — if it's deliberate, feel free to close this.

(Checked at d0a3c0b626b5bebc3bef4742eec05a0242be0bab. Written with AI assistance.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind:bugIndicates an unexpected problem or unintended behavior

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions