64 bit unsigned_int

[abitmore]

We're upgrading unsigned_int type in bitshares-core to 64 bit.

• Change object_id to more than 32 bit bitshares-core#1088
• 64 bits unsigned int bitshares-fc#64

The Python library may need to adapt.

[xeroc]

Good move. Thanks for keeping me posted.

I believe that this would only affect serialization in pybitshares, but there, unsigned_int is not used anywhere but explicit types are used (like UInt32).

closing ...

[abitmore]

The point is we need to use 64 bit data types rather than 32 bit data types. At least, unsigned_int is used in core to serialize object IDs, for example, order_id. I know in bitsharesjs varint32 type was used for this, which should be replaced with varuint64, but I don't know what's used in pybitshares, maybe UInt32? Then some of them need to be replaced with a 64 bit data type (I'm not sure whether all of them need to be replaced though).

Related issue in bitsharesjs is bitshares/bitsharesjs#29.

[xeroc]

Oh! I see. Then pybitshares is indeed affected. Shouldn't be a big deal once I know what parts will change ..