transaction fixes dont work

[913z]

Transaction Fixes dont work. There will be errors in the console. I can't fix it.My ViaVersion's version is 5.9.1
I want to know how to fix it

[Ghost-Kokoro]

please provide your console information

[913z]

[17:04:31] [Client thread/INFO]: [STDERR]: java.lang.NullPointerException: Packet PING has no handler to replace
[17:04:31] [Client thread/INFO]: [STDERR]: at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:811)
[17:04:31] [Client thread/INFO]: [STDERR]: at com.viaversion.viaversion.api.protocol.AbstractProtocol.replaceClientbound(AbstractProtocol.java:174)
[17:04:31] [Client thread/INFO]: [STDERR]: at de.florianmichael.viamcp.ViaMCP.fixTransactions(ViaMCP.java:64)
[17:04:31] [Client thread/INFO]: [STDERR]: at de.florianmichael.viamcp.ViaMCP.(ViaMCP.java:58)
[17:04:31] [Client thread/INFO]: [STDERR]: at de.florianmichael.viamcp.ViaMCP.create(ViaMCP.java:46)
[17:04:31] [Client thread/INFO]: [STDERR]: at net.minecraft.client.Minecraft.init(Minecraft.java:608)
[17:04:31] [Client thread/INFO]: [STDERR]: at net.minecraft.client.Minecraft.run(Minecraft.java:479)
[17:04:31] [Client thread/INFO]: [STDERR]: at net.minecraft.client.main.Main.main(Main.java:115)
[17:04:31] [Client thread/INFO]: [STDERR]: at Start.main(Start.java:9)

The code for the fixTransactions method
private void fixTransactions() {
final Protocol1_17To1_16_4 protocol = Via.getManager().getProtocolManager().getProtocol(Protocol1_17To1_16_4.class);
protocol.replaceClientbound(ClientboundPackets1_17.PING, packetWrapper -> {});
protocol.replaceServerbound(ServerboundPackets1_16_2.CONTAINER_ACK, packetWrapper -> {});
}

[Ghost-Kokoro]

[17:04:31] [Client thread/INFO]: [STDERR]: java.lang.NullPointerException: Packet PING has no handler to replace [17:04:31] [Client thread/INFO]: [STDERR]: at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:811) [17:04:31] [Client thread/INFO]: [STDERR]: at com.viaversion.viaversion.api.protocol.AbstractProtocol.replaceClientbound(AbstractProtocol.java:174) [17:04:31] [Client thread/INFO]: [STDERR]: at de.florianmichael.viamcp.ViaMCP.fixTransactions(ViaMCP.java:64) [17:04:31] [Client thread/INFO]: [STDERR]: at de.florianmichael.viamcp.ViaMCP.(ViaMCP.java:58) [17:04:31] [Client thread/INFO]: [STDERR]: at de.florianmichael.viamcp.ViaMCP.create(ViaMCP.java:46) [17:04:31] [Client thread/INFO]: [STDERR]: at net.minecraft.client.Minecraft.init(Minecraft.java:608) [17:04:31] [Client thread/INFO]: [STDERR]: at net.minecraft.client.Minecraft.run(Minecraft.java:479) [17:04:31] [Client thread/INFO]: [STDERR]: at net.minecraft.client.main.Main.main(Main.java:115) [17:04:31] [Client thread/INFO]: [STDERR]: at Start.main(Start.java:9)

The code for the fixTransactions method private void fixTransactions() { final Protocol1_17To1_16_4 protocol = Via.getManager().getProtocolManager().getProtocol(Protocol1_17To1_16_4.class); protocol.replaceClientbound(ClientboundPackets1_17.PING, packetWrapper -> {}); protocol.replaceServerbound(ServerboundPackets1_16_2.CONTAINER_ACK, packetWrapper -> {}); }

PING packet on 1.17 to 1.16.4 protocols are not registered in via* libs, so use origin code instead, which is registerClient/Serverbound(, , true);

[913z]

it don't work

[17:26:46] [Via-Mappingloader-2/ERROR]: Error during loading of Protocol1_17To1_16_4
java.util.concurrent.CompletionException: java.lang.IllegalArgumentException: Packet type CONTAINER_ACK already registered! If override is intentional, use replaceServerbound instead.
at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) [?:?]
at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) [?:?]
at java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:791) [?:?]
at java.util.concurrent.CompletableFuture$Completion.exec(CompletableFuture.java:483) [?:?]
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) [?:?]
at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) [?:?]
at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) [?:?]
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) [?:?]
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) [?:?]
Caused by: java.lang.IllegalArgumentException: Packet type CONTAINER_ACK already registered! If override is intentional, use replaceServerbound instead.
at com.viaversion.viaversion.api.protocol.AbstractProtocol.register(AbstractProtocol.java:410) ~[ViaVersion-5.9.1-downgraded.jar:?]
at com.viaversion.viaversion.api.protocol.AbstractProtocol.registerServerbound(AbstractProtocol.java:387) ~[ViaVersion-5.9.1-downgraded.jar:?]
at com.viaversion.viaversion.api.protocol.Protocol.registerServerbound(Protocol.java:184) ~[ViaVersion-5.9.1-downgraded.jar:?]
at com.viaversion.viabackwards.protocol.v1_17to1_16_4.rewriter.BlockItemPacketRewriter1_17.registerPackets(BlockItemPacketRewriter1_17.java:163) ~[ViaBackwards-5.9.1-downgraded.jar:?]
at com.viaversion.viaversion.api.rewriter.RewriterBase.register(RewriterBase.java:36) ~[ViaVersion-5.9.1-downgraded.jar:?]
at com.viaversion.viaversion.api.protocol.AbstractProtocol.callRegister(AbstractProtocol.java:239) ~[ViaVersion-5.9.1-downgraded.jar:?]
at com.viaversion.viaversion.api.protocol.AbstractProtocol.registerPackets(AbstractProtocol.java:223) ~[ViaVersion-5.9.1-downgraded.jar:?]
at com.viaversion.viabackwards.protocol.v1_17to1_16_4.Protocol1_17To1_16_4.registerPackets(Protocol1_17To1_16_4.java:71) ~[ViaBackwards-5.9.1-downgraded.jar:?]
at com.viaversion.viaversion.api.protocol.AbstractProtocol.initialize(AbstractProtocol.java:117) ~[ViaVersion-5.9.1-downgraded.jar:?]
at com.viaversion.viaversion.api.protocol.AbstractProtocol.loadMappingData(AbstractProtocol.java:214) ~[ViaVersion-5.9.1-downgraded.jar:?]
at java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:787) ~[?:?]
... 6 more

private void fixTransactions() {
final Protocol1_17To1_16_4 protocol = Via.getManager().getProtocolManager().getProtocol(Protocol1_17To1_16_4.class);
protocol.registerClientbound(ClientboundPackets1_17.PING, ClientboundPackets1_16_2.CONTAINER_ACK, wrapper -> {}, true);
protocol.registerServerbound(ServerboundPackets1_16_2.CONTAINER_ACK, ServerboundPackets1_17.PONG, wrapper -> {}, true);
}

[Ghost-Kokoro]

it don't work

[17:26:46] [Via-Mappingloader-2/ERROR]: Error during loading of Protocol1_17To1_16_4 java.util.concurrent.CompletionException: java.lang.IllegalArgumentException: Packet type CONTAINER_ACK already registered! If override is intentional, use replaceServerbound instead. at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) [?:?] at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) [?:?] at java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:791) [?:?] at java.util.concurrent.CompletableFuture$Completion.exec(CompletableFuture.java:483) [?:?] at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) [?:?] at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) [?:?] at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) [?:?] at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) [?:?] at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) [?:?] Caused by: java.lang.IllegalArgumentException: Packet type CONTAINER_ACK already registered! If override is intentional, use replaceServerbound instead. at com.viaversion.viaversion.api.protocol.AbstractProtocol.register(AbstractProtocol.java:410) ~[ViaVersion-5.9.1-downgraded.jar:?] at com.viaversion.viaversion.api.protocol.AbstractProtocol.registerServerbound(AbstractProtocol.java:387) ~[ViaVersion-5.9.1-downgraded.jar:?] at com.viaversion.viaversion.api.protocol.Protocol.registerServerbound(Protocol.java:184) ~[ViaVersion-5.9.1-downgraded.jar:?] at com.viaversion.viabackwards.protocol.v1_17to1_16_4.rewriter.BlockItemPacketRewriter1_17.registerPackets(BlockItemPacketRewriter1_17.java:163) ~[ViaBackwards-5.9.1-downgraded.jar:?] at com.viaversion.viaversion.api.rewriter.RewriterBase.register(RewriterBase.java:36) ~[ViaVersion-5.9.1-downgraded.jar:?] at com.viaversion.viaversion.api.protocol.AbstractProtocol.callRegister(AbstractProtocol.java:239) ~[ViaVersion-5.9.1-downgraded.jar:?] at com.viaversion.viaversion.api.protocol.AbstractProtocol.registerPackets(AbstractProtocol.java:223) ~[ViaVersion-5.9.1-downgraded.jar:?] at com.viaversion.viabackwards.protocol.v1_17to1_16_4.Protocol1_17To1_16_4.registerPackets(Protocol1_17To1_16_4.java:71) ~[ViaBackwards-5.9.1-downgraded.jar:?] at com.viaversion.viaversion.api.protocol.AbstractProtocol.initialize(AbstractProtocol.java:117) ~[ViaVersion-5.9.1-downgraded.jar:?] at com.viaversion.viaversion.api.protocol.AbstractProtocol.loadMappingData(AbstractProtocol.java:214) ~[ViaVersion-5.9.1-downgraded.jar:?] at java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:787) ~[?:?] ... 6 more

private void fixTransactions() { final Protocol1_17To1_16_4 protocol = Via.getManager().getProtocolManager().getProtocol(Protocol1_17To1_16_4.class); protocol.registerClientbound(ClientboundPackets1_17.PING, ClientboundPackets1_16_2.CONTAINER_ACK, wrapper -> {}, true); protocol.registerServerbound(ServerboundPackets1_16_2.CONTAINER_ACK, ServerboundPackets1_17.PONG, wrapper -> {}, true); }

what's your native version? are you editing a mcp client or mixin based client

[913z]

i am editing a mcp client.ViaVersion 5.9.1, ViaRewind 4.1.1, ViaBackward 5.9.1

[Ghost-Kokoro]

i am editing a mcp client.ViaVersion 5.9.1, ViaRewind 4.1.1, ViaBackward 5.9.1

Downgrade your via* libs to 5.8.x, otherwise you should make it possible to inject the fix codes into the last protocol chain like I said in the document.

[Ghost-Kokoro]

https://github.com/ViaVersionMCP/ViaMCP#:~:text=For%20example%20if%20you%20are%20on%201.8%2C%20inject%20your%20code%20to%20the%20end%20of%20registerPackets()%20in%20Protocol1_9To1_8.class.%20if%20you%20are%20on%201.12.2%2C%20it%27s%20in%20Protocol1_13To1_12_2.class.

[913z]

i want to know how to inject the fix codes into the last protocol? the document seems to not have any specific steps.

[Ghost-Kokoro]

i want to know how to inject the fix codes into the last protocol? the document seems to not have any specific steps.

It depends on development environment, like forge uses asm/mixin to inject and fabric uses mixin. Since you are coding a mcp client, I'm afraid you must code a injection base yourself.
Since the update of 5.9.0, viaversion developers have implemented a more strict packet register system, which makes protocol override before their loading base impossible. So I suggest to downgrade the via* libs version, that's the easiest way to fix this.

[Ghost-Kokoro]

i want to know how to inject the fix codes into the last protocol? the document seems to not have any specific steps.

For mixin, just inject the codes to registerPackets() at the "RETURN" inject point in the last chain of your protocol.
For asm, visit the method like mixin, then insert MehodInsnNode call.