From ec2c621991bfe55b7223b58bf1d723427d557346 Mon Sep 17 00:00:00 2001 From: Thierry Boileau Date: Fri, 5 Jun 2026 17:41:02 +0200 Subject: [PATCH 1/2] feat(QTDI-2979): Add labelDisplayMode attribute to @Suggestable Add a LabelDisplayMode enum (LABEL, LABEL_ID) and a labelDisplayMode() annotation attribute to @Suggestable. The attribute defaults to LABEL, preserving full backward compatibility. When two or more suggestions share the same label, setting labelDisplayMode = LABEL_ID allows the front-end to show both the label and the opaque identifier so the user can make an unambiguous choice (e.g. 'Paris (fr-paris-01)'). The value is serialised as tcomp::action::suggestions::labelDisplayMode in the component metadata map by the existing ActionParameterEnricher, with no changes to component-server-model required. Also includes Spotless reformatting of several pre-existing violations caught during mvn spotless:apply, and a .gitignore update for ai-commons tooling files. Co-Authored-By: GitHub Copilot --- .gitignore | 7 +++ .../api/configuration/action/Suggestable.java | 28 ++++++++++++ .../component/runtime/reflect/Defaults.java | 9 ++-- .../runtime/record/PluralRecordExtension.java | 2 +- .../runtime/manager/ComponentManager.java | 9 ++-- .../reflect/ParameterModelService.java | 10 ++--- .../manager/reflect/ReflectionService.java | 9 ++-- .../runtime/manager/service/InjectorImpl.java | 3 +- .../runtime/manager/ComponentManagerTest.java | 3 +- .../manager/ConfigurationMigrationTest.java | 40 ++++++++++------- .../manager/ReflectionServiceTest.java | 6 ++- .../ActionParameterEnricherTest.java | 39 ++++++++++++++++ .../service/RecordServiceImplTest.java | 45 ++++++++++--------- 13 files changed, 150 insertions(+), 60 deletions(-) diff --git a/.gitignore b/.gitignore index 6d5702c1c74ef..ce463d6bc58d5 100644 --- a/.gitignore +++ b/.gitignore @@ -66,3 +66,10 @@ documentation/rebuildpdf.bat .envrc .env *.versionsBackup + +# ai-commons knowledge base (managed by ai-commons/setup.sh) +.ai-commons/ +.ai-commons/sessions/ +.ai-commons/skills/manage-zephyr-test-cases/references/.env +.claude/CLAUDE.md +.github/copilot-instructions.md diff --git a/component-api/src/main/java/org/talend/sdk/component/api/configuration/action/Suggestable.java b/component-api/src/main/java/org/talend/sdk/component/api/configuration/action/Suggestable.java index 3bebaa94ea17d..b31143d30f116 100644 --- a/component-api/src/main/java/org/talend/sdk/component/api/configuration/action/Suggestable.java +++ b/component-api/src/main/java/org/talend/sdk/component/api/configuration/action/Suggestable.java @@ -74,4 +74,32 @@ * @return parameters for the validation. */ String[] parameters() default { "." }; + + /** + * Controls how each suggestion option is rendered in the UI. + * Use {@link LabelDisplayMode#LABEL_ID} when option labels may not be unique, + * so that the identifier is shown alongside the label to allow unambiguous selection. + * Defaults to {@link LabelDisplayMode#LABEL} — preserves full backward compatibility. + * + * @return the display mode for suggestion options. + */ + LabelDisplayMode labelDisplayMode() default LabelDisplayMode.LABEL; + + /** + * Defines how suggestion options are displayed in the UI. + */ + enum LabelDisplayMode { + + /** + * Display the option label only. + * Default behaviour — use this when labels are unique. + */ + LABEL, + + /** + * Display both the label and the identifier, e.g. {@code Paris (fr-paris-01)}. + * Use this when labels may not be unique so that the user can make an unambiguous choice. + */ + LABEL_ID + } } diff --git a/component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/reflect/Defaults.java b/component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/reflect/Defaults.java index 98db632afb7ae..d632994d510a9 100644 --- a/component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/reflect/Defaults.java +++ b/component-runtime-impl/src/main/java/org/talend/sdk/component/runtime/reflect/Defaults.java @@ -63,10 +63,11 @@ public class Defaults { .invokeWithArguments(args); } else { // j > 8 - can need some --add-opens, we will add a module-info later to be clean when dropping j8 final Method privateLookup = findPrivateLookup(); - HANDLER = (clazz, method, proxy, args) -> ((MethodHandles.Lookup) privateLookup.invoke(null, clazz, constructor.newInstance(clazz))) - .unreflectSpecial(method, clazz) - .bindTo(proxy) - .invokeWithArguments(args); + HANDLER = (clazz, method, proxy, + args) -> ((MethodHandles.Lookup) privateLookup.invoke(null, clazz, constructor.newInstance(clazz))) + .unreflectSpecial(method, clazz) + .bindTo(proxy) + .invokeWithArguments(args); } } diff --git a/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/PluralRecordExtension.java b/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/PluralRecordExtension.java index 7f53b27b52b5a..135526c66418f 100644 --- a/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/PluralRecordExtension.java +++ b/component-runtime-impl/src/test/java/org/talend/sdk/component/runtime/record/PluralRecordExtension.java @@ -58,7 +58,7 @@ private Jsonb getJsonb(Jsonb jsonb) { // create a Jsonb instance which is PojoJsonbProvider as in component-runtime-manager return (Jsonb) Proxy .newProxyInstance(Thread.currentThread().getContextClassLoader(), - new Class[]{Jsonb.class, PojoJsonbProvider.class}, (proxy, method, args) -> { + new Class[] { Jsonb.class, PojoJsonbProvider.class }, (proxy, method, args) -> { if (method.getDeclaringClass() == Supplier.class) { return jsonb; } diff --git a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java index c68698476beae..74187043d32da 100644 --- a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java +++ b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java @@ -1924,7 +1924,8 @@ public void onPartitionMapper(final Class type, final PartitionMapper partiti () -> { final List params = parameterModelService .buildParameterMetas(constructor, getPackage(type), - new BaseParameterEnricher.Context((LocalConfiguration) services.getServices().get(LocalConfiguration.class))); + new BaseParameterEnricher.Context((LocalConfiguration) services.getServices() + .get(LocalConfiguration.class))); if (infinite) { if (partitionMapper.stoppable()) { addInfiniteMapperBuiltInParameters(type, params); @@ -1977,7 +1978,8 @@ public void onEmitter(final Class type, final Emitter emitter) { final Supplier> parameterMetas = lazy(() -> executeInContainer(plugin, () -> parameterModelService .buildParameterMetas(constructor, getPackage(type), - new BaseParameterEnricher.Context((LocalConfiguration) services.getServices().get(LocalConfiguration.class))))); + new BaseParameterEnricher.Context((LocalConfiguration) services.getServices() + .get(LocalConfiguration.class))))); final Function, Object[]> parameterFactory = createParametersFactory(plugin, constructor, services.getServices(), parameterMetas); final String name = of(emitter.name()).filter(n -> !n.isEmpty()).orElseGet(type::getName); @@ -2161,7 +2163,8 @@ public void onDriverRunner(final Class type, final DriverRunner processor) { final Supplier> parameterMetas = lazy(() -> executeInContainer(plugin, () -> parameterModelService .buildParameterMetas(constructor, getPackage(type), - new BaseParameterEnricher.Context((LocalConfiguration) services.getServices().get(LocalConfiguration.class))))); + new BaseParameterEnricher.Context((LocalConfiguration) services.getServices() + .get(LocalConfiguration.class))))); final Function, Object[]> parameterFactory = createParametersFactory(plugin, constructor, services.getServices(), parameterMetas); final String name = of(processor.name()).filter(n -> !n.isEmpty()).orElseGet(type::getName); diff --git a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ParameterModelService.java b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ParameterModelService.java index 38619cf3f577b..42765f5e0ad96 100644 --- a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ParameterModelService.java +++ b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ParameterModelService.java @@ -254,10 +254,10 @@ private Stream getReflectionAnnotations(final Type genericType, fina .concat(Stream.of(annotations), // if a class concat its annotations genericType instanceof Class - ? getClassAnnotations(genericType, annotations) - : (hasAClassFirstParameter(genericType) ? getClassAnnotations( - ((ParameterizedType) genericType).getActualTypeArguments()[0], - annotations) : Stream.empty())); + ? getClassAnnotations(genericType, annotations) + : (hasAClassFirstParameter(genericType) ? getClassAnnotations( + ((ParameterizedType) genericType).getActualTypeArguments()[0], + annotations) : Stream.empty())); } private boolean hasAClassFirstParameter(final Type genericType) { @@ -297,7 +297,7 @@ private List buildParametersMetas(final String name, final String } return Stream .concat(buildParametersMetas(name + ".key[${index}]", prefix + "key[${index}].", - (Class) pt.getActualTypeArguments()[0], annotations, i18nPackages, ignoreI18n, + (Class) pt.getActualTypeArguments()[0], annotations, i18nPackages, ignoreI18n, context).stream(), buildParametersMetas(name + ".value[${index}]", prefix + "value[${index}].", (Class) pt.getActualTypeArguments()[1], annotations, i18nPackages, diff --git a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ReflectionService.java b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ReflectionService.java index 14e221e164dcc..c51d67bf8ec7c 100644 --- a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ReflectionService.java +++ b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/reflect/ReflectionService.java @@ -524,10 +524,11 @@ private Object createObject(final ClassLoader loader, final Function list = (Collection) createList(loader, contextualSupplier, prefix + enclosingName, List.class, - arrayClass.getComponentType(), toList(), createObjectFactory(loader, - contextualSupplier, arrayClass.getComponentType(), metas, precomputed), - new HashMap<>(listEntries), metas, precomputed); + final Collection list = + (Collection) createList(loader, contextualSupplier, prefix + enclosingName, List.class, + arrayClass.getComponentType(), toList(), createObjectFactory(loader, + contextualSupplier, arrayClass.getComponentType(), metas, precomputed), + new HashMap<>(listEntries), metas, precomputed); // we need that conversion to ensure the type matches final Object array = Array.newInstance(arrayClass.getComponentType(), list.size()); diff --git a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/InjectorImpl.java b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/InjectorImpl.java index 35573ae45a40f..3db94016340e4 100644 --- a/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/InjectorImpl.java +++ b/component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/InjectorImpl.java @@ -128,7 +128,8 @@ private void doInject(final Class type, final T instance) { }) .forEach(field -> { try { - final Class configClass = (Class) ((ParameterizedType) field.getGenericType()).getActualTypeArguments()[0]; + final Class configClass = + (Class) ((ParameterizedType) field.getGenericType()).getActualTypeArguments()[0]; final ClassLoader loader = Thread.currentThread().getContextClassLoader(); final Supplier supplier = () -> { try { diff --git a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ComponentManagerTest.java b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ComponentManagerTest.java index 3aca230e76ffd..d9ef11418ea2b 100644 --- a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ComponentManagerTest.java +++ b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ComponentManagerTest.java @@ -611,7 +611,8 @@ void testLocalConfigurationFromEnvironment(@TempDir final File temporaryFolder) manager.addPlugin(plugin.getAbsolutePath()); final Container container = manager.getContainer().findAll().stream().findFirst().orElse(null); assertNotNull(container); - final LocalConfiguration envConf = (LocalConfiguration) container.get(AllServices.class).getServices().get(LocalConfiguration.class); + final LocalConfiguration envConf = + (LocalConfiguration) container.get(AllServices.class).getServices().get(LocalConfiguration.class); // check translated env vars assertEquals("/home/user", envConf.get("USER_PATH")); assertEquals("/home/user", envConf.get("USER.PATH")); diff --git a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ConfigurationMigrationTest.java b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ConfigurationMigrationTest.java index 11e4cf10371e9..ae2e86cda2cfb 100644 --- a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ConfigurationMigrationTest.java +++ b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ConfigurationMigrationTest.java @@ -42,12 +42,14 @@ void run(@TempDir final Path temporaryFolder) throws Exception { "META-INF/test/dependencies", "org.talend.test:type=plugin,value=%s")) { manager.addPlugin(jar.getAbsolutePath()); { - final Object nested = ((ProcessorImpl) manager.findProcessor("chain", "configured1", 0, new HashMap() { + final Object nested = ((ProcessorImpl) manager + .findProcessor("chain", "configured1", 0, new HashMap() { - { - put("config.__version", "-1"); - } - }).orElseThrow(IllegalStateException::new)) + { + put("config.__version", "-1"); + } + }) + .orElseThrow(IllegalStateException::new)) .getDelegate(); final Object config = get(nested, "getConfig"); @@ -55,13 +57,15 @@ void run(@TempDir final Path temporaryFolder) throws Exception { assertEquals("ok", get(config, "getName")); } { - final Object nested = ((ProcessorImpl) manager.findProcessor("chain", "configured2", 0, new HashMap() { + final Object nested = ((ProcessorImpl) manager + .findProcessor("chain", "configured2", 0, new HashMap() { - { - put("config.__version", "0"); - put("value.__version", "-1"); - } - }).orElseThrow(IllegalStateException::new)) + { + put("config.__version", "0"); + put("value.__version", "-1"); + } + }) + .orElseThrow(IllegalStateException::new)) .getDelegate(); assertEquals("set", get(nested, "getValue")); @@ -70,13 +74,15 @@ void run(@TempDir final Path temporaryFolder) throws Exception { assertEquals("ok", get(config, "getName")); } { - final Object nested = ((ProcessorImpl) manager.findProcessor("chain", "migrationtest", -1, new HashMap() { + final Object nested = ((ProcessorImpl) manager + .findProcessor("chain", "migrationtest", -1, new HashMap() { - { - put("config.__version", "1"); - put("config.datastore.__version", "1"); - } - }).orElseThrow(IllegalStateException::new)) + { + put("config.__version", "1"); + put("config.datastore.__version", "1"); + } + }) + .orElseThrow(IllegalStateException::new)) .getDelegate(); final Object config = get(nested, "getConfig"); diff --git a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ReflectionServiceTest.java b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ReflectionServiceTest.java index 836bc2336470f..09a7aecc5d5c2 100644 --- a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ReflectionServiceTest.java +++ b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/ReflectionServiceTest.java @@ -450,8 +450,10 @@ void copiable() throws NoSuchMethodException { new HttpClientFactoryImpl("test", reflectionService, JsonbBuilder.create(), emptyMap()) .create(UserHttpClient.class, "http://foo")); final Method httpMtd = TableOwner.class.getMethod("http", UserHttpClient.class); - final HttpClient client1 = (HttpClient) reflectionService.parameterFactory(httpMtd, precomputed, null).apply(emptyMap())[0]; - final HttpClient client2 = (HttpClient) reflectionService.parameterFactory(httpMtd, precomputed, null).apply(emptyMap())[0]; + final HttpClient client1 = + (HttpClient) reflectionService.parameterFactory(httpMtd, precomputed, null).apply(emptyMap())[0]; + final HttpClient client2 = + (HttpClient) reflectionService.parameterFactory(httpMtd, precomputed, null).apply(emptyMap())[0]; assertNotSame(client1, client2); final InvocationHandler handler1 = Proxy.getInvocationHandler(client1); final InvocationHandler handler2 = Proxy.getInvocationHandler(client2); diff --git a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/reflect/parameterenricher/ActionParameterEnricherTest.java b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/reflect/parameterenricher/ActionParameterEnricherTest.java index 695b3501c6baa..d48ade78e347c 100644 --- a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/reflect/parameterenricher/ActionParameterEnricherTest.java +++ b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/reflect/parameterenricher/ActionParameterEnricherTest.java @@ -159,6 +159,7 @@ void suggestion() { { put("tcomp::action::suggestions", "test"); put("tcomp::action::suggestions::parameters", ".,foo,/bar/dummy"); + put("tcomp::action::suggestions::labelDisplayMode", "LABEL"); } }, new ActionParameterEnricher().onParameterAnnotation("testParam", String.class, new Suggestable() { @@ -172,6 +173,44 @@ public String[] parameters() { return new String[] { ".", "foo", "/bar/dummy" }; } + @Override + public LabelDisplayMode labelDisplayMode() { + return LabelDisplayMode.LABEL; + } + + @Override + public Class annotationType() { + return Suggestable.class; + } + })); + } + + @Test + void suggestionWithLabelId() { + assertEquals(new HashMap() { + + { + put("tcomp::action::suggestions", "test"); + put("tcomp::action::suggestions::parameters", "."); + put("tcomp::action::suggestions::labelDisplayMode", "LABEL_ID"); + } + }, new ActionParameterEnricher().onParameterAnnotation("testParam", String.class, new Suggestable() { + + @Override + public String value() { + return "test"; + } + + @Override + public String[] parameters() { + return new String[] { "." }; + } + + @Override + public LabelDisplayMode labelDisplayMode() { + return LabelDisplayMode.LABEL_ID; + } + @Override public Class annotationType() { return Suggestable.class; diff --git a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/RecordServiceImplTest.java b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/RecordServiceImplTest.java index 4002678fd3919..059154dffe389 100644 --- a/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/RecordServiceImplTest.java +++ b/component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/RecordServiceImplTest.java @@ -52,7 +52,8 @@ class RecordServiceImplTest { private final RecordBuilderFactory factory = new RecordBuilderFactoryImpl(null); - private final RecordService service = (RecordService) new DefaultServiceProvider(null, JsonProvider.provider(), Json.createGeneratorFactory(emptyMap()), + private final RecordService service = (RecordService) new DefaultServiceProvider(null, JsonProvider.provider(), + Json.createGeneratorFactory(emptyMap()), Json.createReaderFactory(emptyMap()), Json.createBuilderFactory(emptyMap()), Json.createParserFactory(emptyMap()), Json.createWriterFactory(emptyMap()), new JsonbConfig(), JsonbProvider.provider(), null, null, emptyList(), t -> factory, null) @@ -104,28 +105,28 @@ void visit() { assertEquals(3, service .visit((RecordVisitor) Proxy - .newProxyInstance(Thread.currentThread().getContextClassLoader(), - new Class[]{RecordVisitor.class}, (proxy, method, args) -> { - visited - .add(method.getName() + "/" - + (args == null ? "null" + .newProxyInstance(Thread.currentThread().getContextClassLoader(), + new Class[] { RecordVisitor.class }, (proxy, method, args) -> { + visited + .add(method.getName() + "/" + + (args == null ? "null" : Stream - .of(args) - .filter(it -> !(it instanceof Schema.Entry)) - .collect(Collectors.toList()))); - switch (method.getName()) { - case "get": - return out.incrementAndGet(); - case "apply": - return asList(args) - .stream() - .mapToInt(Integer.class::cast) - .sum(); - default: - return method.getReturnType() == RecordVisitor.class ? proxy - : null; - } - }), + .of(args) + .filter(it -> !(it instanceof Schema.Entry)) + .collect(Collectors.toList()))); + switch (method.getName()) { + case "get": + return out.incrementAndGet(); + case "apply": + return asList(args) + .stream() + .mapToInt(Integer.class::cast) + .sum(); + default: + return method.getReturnType() == RecordVisitor.class ? proxy + : null; + } + }), baseRecord)); assertEquals(asList("onString/[Optional[Test]]", "onInt/[OptionalInt[33]]", "onRecord/[Optional[{\"street\":\"here\",\"number\":1}]]", "onString/[Optional[here]]", From 96f42b7b141ae57daa2dff093bdad6dd12e7e550 Mon Sep 17 00:00:00 2001 From: Thierry Boileau Date: Mon, 8 Jun 2026 16:59:39 +0200 Subject: [PATCH 2/2] fix(QTDI-2979): apply spotless --- .../org/talend/sdk/component/junit5/ComponentExtension.java | 3 ++- .../talend/sdk/component/tools/ComponentValidatorTest.java | 5 +++-- .../java/org/talend/runtime/documentation/Generator.java | 3 ++- .../talend/sdk/component/singer/kitap/RecordJsonMapper.java | 3 ++- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/component-runtime-testing/component-runtime-junit/src/main/java/org/talend/sdk/component/junit5/ComponentExtension.java b/component-runtime-testing/component-runtime-junit/src/main/java/org/talend/sdk/component/junit5/ComponentExtension.java index acb3dd1662862..34705cb7abc0f 100644 --- a/component-runtime-testing/component-runtime-junit/src/main/java/org/talend/sdk/component/junit5/ComponentExtension.java +++ b/component-runtime-testing/component-runtime-junit/src/main/java/org/talend/sdk/component/junit5/ComponentExtension.java @@ -112,7 +112,8 @@ public void doStart(final ExtensionContext extensionContext) { } public void doStop(final ExtensionContext extensionContext) { - ofNullable((EmbeddedComponentManager) extensionContext.getStore(NAMESPACE).get(EmbeddedComponentManager.class.getName())) + ofNullable((EmbeddedComponentManager) extensionContext.getStore(NAMESPACE) + .get(EmbeddedComponentManager.class.getName())) .ifPresent(EmbeddedComponentManager::close); } diff --git a/component-tools/src/test/java/org/talend/sdk/component/tools/ComponentValidatorTest.java b/component-tools/src/test/java/org/talend/sdk/component/tools/ComponentValidatorTest.java index 474b91aedde26..2557c4dd01359 100755 --- a/component-tools/src/test/java/org/talend/sdk/component/tools/ComponentValidatorTest.java +++ b/component-tools/src/test/java/org/talend/sdk/component/tools/ComponentValidatorTest.java @@ -182,8 +182,9 @@ public void beforeEach(final ExtensionContext context) { public void afterEach(final ExtensionContext context) { final ExtensionContext.Store store = context.getStore(NAMESPACE); final boolean fails = !((ComponentPackage) store.get(ComponentPackage.class.getName())).success(); - final String expectedMessage = ((ExceptionSpec) context.getStore(NAMESPACE).get(ExceptionSpec.class.getName())) - .getMessage(); + final String expectedMessage = + ((ExceptionSpec) context.getStore(NAMESPACE).get(ExceptionSpec.class.getName())) + .getMessage(); try { ((ComponentValidator) store.get(ComponentValidator.class.getName())).run(); if (fails) { diff --git a/documentation/src/main/java/org/talend/runtime/documentation/Generator.java b/documentation/src/main/java/org/talend/runtime/documentation/Generator.java index a75a8aad81a99..2f08828472513 100644 --- a/documentation/src/main/java/org/talend/runtime/documentation/Generator.java +++ b/documentation/src/main/java/org/talend/runtime/documentation/Generator.java @@ -373,7 +373,8 @@ private static void generatedScanningExclusions(final File generatedDir) { stream.println("Therefore, the following packages are ignored:"); stream.println(); stream.println("[.talend-filterlist]"); - ((KnownClassesFilter.OptimizedExclusionFilter) ((KnownClassesFilter) KnownClassesFilter.INSTANCE).getDelegateSkip()) + ((KnownClassesFilter.OptimizedExclusionFilter) ((KnownClassesFilter) KnownClassesFilter.INSTANCE) + .getDelegateSkip()) .getIncluded() .stream() .sorted() diff --git a/singer-parent/component-kitap/src/main/java/org/talend/sdk/component/singer/kitap/RecordJsonMapper.java b/singer-parent/component-kitap/src/main/java/org/talend/sdk/component/singer/kitap/RecordJsonMapper.java index 45f84f5a4233d..591c2d79022e8 100644 --- a/singer-parent/component-kitap/src/main/java/org/talend/sdk/component/singer/kitap/RecordJsonMapper.java +++ b/singer-parent/component-kitap/src/main/java/org/talend/sdk/component/singer/kitap/RecordJsonMapper.java @@ -58,7 +58,8 @@ public class RecordJsonMapper implements Function { private final Singer singer; - private final RecordService service = (RecordService) new DefaultServiceProvider(null, JsonProvider.provider(), Json.createGeneratorFactory(emptyMap()), + private final RecordService service = (RecordService) new DefaultServiceProvider(null, JsonProvider.provider(), + Json.createGeneratorFactory(emptyMap()), Json.createReaderFactory(emptyMap()), Json.createBuilderFactory(emptyMap()), Json.createParserFactory(emptyMap()), Json.createWriterFactory(emptyMap()), new JsonbConfig(), JsonbProvider.provider(), null, null, emptyList(), t -> new RecordBuilderFactoryImpl("kitap"), null)