From 348085d3c6f7626139edcfcd5df993708f4f9360 Mon Sep 17 00:00:00 2001 From: Adrien Prokopowicz <6529475+prokopyl@users.noreply.github.com> Date: Wed, 13 May 2026 17:56:14 +0200 Subject: [PATCH 1/7] Enforce MSRV to 1.64 (for now) --- .github/workflows/rust.yml | 6 ++---- Cargo.toml | 1 + 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 934b7767..57cc2243 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -9,16 +9,16 @@ jobs: strategy: matrix: os: [ ubuntu-latest, windows-latest, macOS-latest ] + toolchain: [ "1.64", stable, beta, nightly ] runs-on: ${{ matrix.os }} env: RUSTFLAGS: -D warnings - RUSTDOCFLAGS: -D warnings steps: - uses: actions/checkout@v6 - name: Install rust stable uses: dtolnay/rust-toolchain@stable with: - toolchain: stable + toolchain: ${{ matrix.toolchain }} components: clippy - name: Build Default run: cargo build --workspace --all-targets --verbose @@ -42,5 +42,3 @@ jobs: components: rustfmt - name: Check docs run: cargo doc --all --all-features --no-deps - - name: Check Formatting (rustfmt) - run: cargo fmt --all -- --check diff --git a/Cargo.toml b/Cargo.toml index ec2dc49a..c8f0d3ac 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -20,6 +20,7 @@ categories = ["gui"] repository = "https://github.com/RustAudio/baseview" exclude = [".github"] +rust-version = "1.64.0" [features] default = [] From d33599dd4c18e436787babea8868f1b1482511ea Mon Sep 17 00:00:00 2001 From: Adrien Prokopowicz <6529475+prokopyl@users.noreply.github.com> Date: Wed, 13 May 2026 18:08:19 +0200 Subject: [PATCH 2/7] skip examples in msrv check --- .github/workflows/rust.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 57cc2243..d505d60f 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -9,7 +9,7 @@ jobs: strategy: matrix: os: [ ubuntu-latest, windows-latest, macOS-latest ] - toolchain: [ "1.64", stable, beta, nightly ] + toolchain: [ "1.64", stable ] runs-on: ${{ matrix.os }} env: RUSTFLAGS: -D warnings @@ -21,11 +21,14 @@ jobs: toolchain: ${{ matrix.toolchain }} components: clippy - name: Build Default - run: cargo build --workspace --all-targets --verbose + run: cargo build -p baseview --verbose - name: Build All Features - run: cargo build --workspace --all-targets --all-features --verbose + run: cargo build -p baseview --all-features --verbose - name: Run tests - run: cargo test --workspace --all-targets --all-features --verbose + run: cargo test -p baseview --all-features --verbose + - name: Build examples + if: matrix.toolchain != '1.64' + run: cargo build --workspace --all-targets --verbose - name: Clippy run: cargo clippy --all --all-features -- -D warnings checks: From 4c3a1ca6647db9f8463783a72e03aa3626bb1ca5 Mon Sep 17 00:00:00 2001 From: Adrien Prokopowicz <6529475+prokopyl@users.noreply.github.com> Date: Wed, 13 May 2026 18:14:24 +0200 Subject: [PATCH 3/7] libc requires msrv bump to 1.65 --- .github/workflows/rust.yml | 6 ++++-- Cargo.toml | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index d505d60f..8af7a90d 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -9,7 +9,7 @@ jobs: strategy: matrix: os: [ ubuntu-latest, windows-latest, macOS-latest ] - toolchain: [ "1.64", stable ] + toolchain: [ "1.65", stable ] runs-on: ${{ matrix.os }} env: RUSTFLAGS: -D warnings @@ -27,7 +27,7 @@ jobs: - name: Run tests run: cargo test -p baseview --all-features --verbose - name: Build examples - if: matrix.toolchain != '1.64' + if: matrix.toolchain != '1.65' run: cargo build --workspace --all-targets --verbose - name: Clippy run: cargo clippy --all --all-features -- -D warnings @@ -45,3 +45,5 @@ jobs: components: rustfmt - name: Check docs run: cargo doc --all --all-features --no-deps + - name: Clippy + run: cargo clippy --all --all-features -- -D warnings diff --git a/Cargo.toml b/Cargo.toml index c8f0d3ac..33880080 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -20,7 +20,7 @@ categories = ["gui"] repository = "https://github.com/RustAudio/baseview" exclude = [".github"] -rust-version = "1.64.0" +rust-version = "1.65" [features] default = [] From 694875c9ff94e02f5b663fac21ddf2e8205f5c28 Mon Sep 17 00:00:00 2001 From: Adrien Prokopowicz <6529475+prokopyl@users.noreply.github.com> Date: Wed, 13 May 2026 18:29:47 +0200 Subject: [PATCH 4/7] libloading requires msrv bump to 1.71 --- .github/workflows/rust.yml | 4 ++-- Cargo.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 8af7a90d..5ef31136 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -9,7 +9,7 @@ jobs: strategy: matrix: os: [ ubuntu-latest, windows-latest, macOS-latest ] - toolchain: [ "1.65", stable ] + toolchain: [ "1.71", stable ] runs-on: ${{ matrix.os }} env: RUSTFLAGS: -D warnings @@ -27,7 +27,7 @@ jobs: - name: Run tests run: cargo test -p baseview --all-features --verbose - name: Build examples - if: matrix.toolchain != '1.65' + if: matrix.toolchain != '1.71' run: cargo build --workspace --all-targets --verbose - name: Clippy run: cargo clippy --all --all-features -- -D warnings diff --git a/Cargo.toml b/Cargo.toml index 33880080..424f3b3b 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -20,7 +20,7 @@ categories = ["gui"] repository = "https://github.com/RustAudio/baseview" exclude = [".github"] -rust-version = "1.65" +rust-version = "1.71" [features] default = [] From 1a36daffae3ef00e6fce9676aac2a7c59d2e7059 Mon Sep 17 00:00:00 2001 From: Adrien Prokopowicz <6529475+prokopyl@users.noreply.github.com> Date: Wed, 13 May 2026 21:53:07 +0200 Subject: [PATCH 5/7] LazyLock requires msrv bump to 1.80 --- .github/workflows/rust.yml | 4 ++-- Cargo.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 5ef31136..6a664bd8 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -9,7 +9,7 @@ jobs: strategy: matrix: os: [ ubuntu-latest, windows-latest, macOS-latest ] - toolchain: [ "1.71", stable ] + toolchain: [ "1.80", stable ] runs-on: ${{ matrix.os }} env: RUSTFLAGS: -D warnings @@ -27,7 +27,7 @@ jobs: - name: Run tests run: cargo test -p baseview --all-features --verbose - name: Build examples - if: matrix.toolchain != '1.71' + if: matrix.toolchain != '1.80' run: cargo build --workspace --all-targets --verbose - name: Clippy run: cargo clippy --all --all-features -- -D warnings diff --git a/Cargo.toml b/Cargo.toml index 424f3b3b..d3b4d83a 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -20,7 +20,7 @@ categories = ["gui"] repository = "https://github.com/RustAudio/baseview" exclude = [".github"] -rust-version = "1.71" +rust-version = "1.80" [features] default = [] From 116926c85363b925bab64118e0205f37c7c0b562 Mon Sep 17 00:00:00 2001 From: Adrien Prokopowicz <6529475+prokopyl@users.noreply.github.com> Date: Fri, 15 May 2026 15:54:28 +0200 Subject: [PATCH 6/7] Fix rebase --- .github/workflows/rust.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 6a664bd8..2d4d47c8 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -45,5 +45,5 @@ jobs: components: rustfmt - name: Check docs run: cargo doc --all --all-features --no-deps - - name: Clippy - run: cargo clippy --all --all-features -- -D warnings + - name: Check Formatting (rustfmt) + run: cargo fmt --all -- --check From 7509fdb80641e14fdb1627b99a80aa072c01c270 Mon Sep 17 00:00:00 2001 From: Adrien Prokopowicz <6529475+prokopyl@users.noreply.github.com> Date: Fri, 15 May 2026 15:58:50 +0200 Subject: [PATCH 7/7] Skip clippy on MSRV --- .github/workflows/rust.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 2d4d47c8..5ae33fb2 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -30,6 +30,7 @@ jobs: if: matrix.toolchain != '1.80' run: cargo build --workspace --all-targets --verbose - name: Clippy + if: matrix.toolchain != '1.80' run: cargo clippy --all --all-features -- -D warnings checks: runs-on: ubuntu-latest