Fix two spaces in simflags causing silent error#264
Merged
arun3688 merged 3 commits intoApr 29, 2025
Conversation
Otherwise, it could fail silently (e.g. invalid command line option error is only printed to stdout and not stderr).
Contributor
Author
|
Good idea. Feel free to cherry-pick the first commit into your pull request. The second one is redundant. Ping me after you've done that and I will close this PR. |
Contributor
|
@ondras12345 will do a cherry-pick; currently more changes to _run_cmd() are planned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.