From aa80ddfb3a313ddbd9128fce338dfbd6be141385 Mon Sep 17 00:00:00 2001
From: Simon Schulte <github@neokil.de>
Date: Fri, 15 May 2026 13:57:31 +0200
Subject: [PATCH] Remove Shortcut references from discover modal

---
 web/src/DiscoverTicketsModal.tsx              |  6 +-
 .../__tests__/DiscoverTicketsModal.test.tsx   | 64 +++++++++++++++++++
 2 files changed, 67 insertions(+), 3 deletions(-)
 create mode 100644 web/src/__tests__/DiscoverTicketsModal.test.tsx

diff --git a/web/src/DiscoverTicketsModal.tsx b/web/src/DiscoverTicketsModal.tsx
index 00a84dd..7c7825f 100644
--- a/web/src/DiscoverTicketsModal.tsx
+++ b/web/src/DiscoverTicketsModal.tsx
@@ -14,12 +14,12 @@ export function DiscoverTicketsModal({ repoPath, tickets, loading, error, onAdd,
     <div className="modal-backdrop" onClick={onClose}>
       <div className="modal discover-modal" onClick={(event) => event.stopPropagation()}>
         <h3>Discover Tickets</h3>
-        <p className="meta">Shortcut stories tagged "auto-pr" that are not done or in progress for {repoPath}.</p>
+        <p className="meta">Available tickets for {repoPath}.</p>
         {error ? <div className="banner error">{error}</div> : null}
         {loading ? (
-          <p className="meta">Searching Shortcut...</p>
+          <p className="meta">Fetching Tickets...</p>
         ) : tickets.length === 0 && !error ? (
-          <p className="meta">No matching tickets found.</p>
+          <p className="meta">No Tickets available.</p>
         ) : (
           <ul className="discover-list">
             {tickets.map((ticket) => (
diff --git a/web/src/__tests__/DiscoverTicketsModal.test.tsx b/web/src/__tests__/DiscoverTicketsModal.test.tsx
new file mode 100644
index 0000000..c8ca14e
--- /dev/null
+++ b/web/src/__tests__/DiscoverTicketsModal.test.tsx
@@ -0,0 +1,64 @@
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { render, screen, fireEvent } from "@testing-library/react";
+import { DiscoverTicketsModal } from "../DiscoverTicketsModal";
+
+const defaultProps = {
+  repoPath: "/repo/path",
+  tickets: [],
+  loading: false,
+  error: "",
+  onAdd: vi.fn(),
+  onClose: vi.fn(),
+};
+
+beforeEach(() => vi.clearAllMocks());
+
+describe("DiscoverTicketsModal", () => {
+  it("renders generic copy without Shortcut references", () => {
+    render(<DiscoverTicketsModal {...defaultProps} />);
+
+    expect(screen.getByText("Available tickets for /repo/path.")).toBeInTheDocument();
+    expect(screen.getByText("No Tickets available.")).toBeInTheDocument();
+    expect(screen.queryByText(/shortcut/i)).not.toBeInTheDocument();
+  });
+
+  it("shows generic loading copy", () => {
+    render(<DiscoverTicketsModal {...defaultProps} loading />);
+
+    expect(screen.getByText("Fetching Tickets...")).toBeInTheDocument();
+    expect(screen.queryByText(/shortcut/i)).not.toBeInTheDocument();
+  });
+
+  it("renders discovered tickets and calls onAdd", () => {
+    const onAdd = vi.fn();
+    render(
+      <DiscoverTicketsModal
+        {...defaultProps}
+        tickets={[
+          { ticket_number: "GH-4", title: "Remove Shortcut references" },
+          { ticket_number: "SC-1", title: "Another ticket" }
+        ]}
+        onAdd={onAdd}
+      />
+    );
+
+    fireEvent.click(screen.getAllByRole("button", { name: "Add" })[0]);
+    expect(onAdd).toHaveBeenCalledWith("GH-4");
+  });
+
+  it("calls onClose when the backdrop is clicked", () => {
+    const onClose = vi.fn();
+    const { container } = render(<DiscoverTicketsModal {...defaultProps} onClose={onClose} />);
+
+    fireEvent.click(container.querySelector(".modal-backdrop")!);
+    expect(onClose).toHaveBeenCalledOnce();
+  });
+
+  it("does not call onClose when the modal body is clicked", () => {
+    const onClose = vi.fn();
+    const { container } = render(<DiscoverTicketsModal {...defaultProps} onClose={onClose} />);
+
+    fireEvent.click(container.querySelector(".modal")!);
+    expect(onClose).not.toHaveBeenCalled();
+  });
+});