Use Custom Marker Error

[jeannettestrand]

From the StoryMap ReadMe:

"Images can now be used in place of map pins. Use image inside the location object and include a url to use. use_custom_markers also has to be set to true in the story map options. Same goes for custom icons except you need icon inside the location object and include a url to use."

The slide->location->image property is not working; slide->location->icon IS working. When requesting a custom image in place of map pins, the following error is thrown, with the following stack trace:

[Show/hide message details.] ReferenceError: url is not defined[Learn More] storymap-min.js:12:24806
_createImage
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:12:24806
_createMarker
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:12:23638
_initLayout
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:12:14681
initialize
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:12:14025
NewClass
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:5:11125
_createMarker
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:12:30845
_createMarkers
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:12:19983
_initData
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:12:22842
initialize
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:12:16114
NewClass
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:5:11125
_initLayout
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:13:10587
_onDataLoaded
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:13:14759
_loadLanguage
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:13:9690
_initOptions
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:13:9402
_initData/<
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:13:8642
ajaxSuccess
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:5:2268
$.ajax/xhr.onreadystatechange
https://cdn.knightlab.com/libs/storymapjs/latest/js/storymap-min.js:5:7344

[scott2b]

Is this error being produced in the editor or in the published storymap? If it is the editor, is it happening at storymap.knightlab.com, or is this specific to a localized development environment?

[scott2b]

I am not sure if this is the same issue @bysimeon but it does seem like custom icons are broken in local development. I suspect this may have just been an oversight in developing the new local storage mechanism for development.

[scott2b]

cf. Zendesk ticket # 5952

[LarsGeogecko]

Hi,

Are there any updates to this issue?

[jeannettestrand]

Is this error being produced in the editor or in the published storymap? If it is the editor, is it happening at storymap.knightlab.com, or is this specific to a localized development environment?

The issue is coming up with local development, configured as per the application README, and across different development environments as well.

[LarsGeogecko]

Hi, The error is being produced for local development environment. There seem to be an issue somewhere, where the setting is being overwritten by some default parameter. Here is the code: { "date": "", "location": { "use-custom_icon": true, "icon": "http://maps.gstatic.com/intl/ en_us/mapfiles/ms/micons/blue-pushpin.png", "lat": 37.7185903255881677, "line": true, "lon": -35.5078125, "zoom": 4 }, "background": { "color": "#c4c0c0" }, "media": { "caption": "caption", "credit": "credit", "url": "https://i.ytimg.com/vi/xVbLM_ iNLWk/maxresdefault.jpg" }, "text": { "headline": "Producer", "text": "<span>These are the farmers responsible for the production phase of the value chain.<p> For leafy vegetables, this stage involves preparation gardening, vegetable planting, crop management, harvesting and initial sorting and grading for market.<p>For mushrooms, it involves soaking, sorting and fermentation, sterilization, spawning, watering, regulating temperature and humidity and then harvesting</span>" } } So its related to the use cutom icon: true part, it seems like that part is being overwritten. "use-custom_icon": true, "icon": "http://maps.gstatic.com/intl/ en_us/mapfiles/ms/micons/blue-pushpin.png",

…

On 13 September 2018 at 03:51, Jeannette Strand ***@***.***> wrote: Is this error being produced in the editor or in the published storymap? If it is the editor, is it happening at storymap.knightlab.com, or is this specific to a localized development environment? The issue is coming up with local development, configured as per the application README — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#405 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AfxENOVOe-PRM_vjRmwCfLkl2V6oTEMfks5uaawZgaJpZM4WASPY> .

[jeannettestrand]

I am not sure if this is the same issue @bysimeon but it does seem like custom icons are broken in local development. I suspect this may have just been an oversight in developing the new local storage mechanism for development.

I think I have resolved this issue, it appears that in VCO.MapMarker.Leaflet.js file, the url for the custom-icon-image was not being assigned; I have put this change in a pull request, this is the fork: TileLayer.WMS feature #409 jeannettestrand/StoryMapJS-1