Skip to content

Reference image update#158

Open
AshtonSBradley wants to merge 8 commits into
Kolaru:masterfrom
AshtonSBradley:asb/reference-image-update
Open

Reference image update#158
AshtonSBradley wants to merge 8 commits into
Kolaru:masterfrom
AshtonSBradley:asb/reference-image-update

Conversation

@AshtonSBradley
Copy link
Copy Markdown
Contributor

Summary

  • Updates the reference image test harness to look for a refimages-v3 release asset.
  • Fixes the @inof typo that currently stops reference/compare.jl before image comparison can run.
  • Creates nested output directories before saving comparison artifacts, so failures for paths such as basics/punctuation.png and spacing/...png upload useful images.

Explanation

The current ReferenceTests workflow fails before it can provide useful comparison artifacts. First, the script hits a typo in an added logging call. After that is fixed, nested reference image paths need their parent directories created before save writes comparison figures.

This PR keeps the existing release-asset model for reference images and changes the default reference tag from refimages-v2 to refimages-v3. The refreshed archive is not committed because *.tar is ignored by the repository; it should be uploaded as the reference_images.tar asset for the new refimages-v3 release.

Sorry for the extra follow-up here. This is only provided in case it might be useful; please ignore if not.

Refreshed archive candidate:

  • File: /private/tmp/MathTeXEngine-reference_images-refreshed.tar
  • SHA256: faa877773479c148e600bf35de5573c4d87fbc4c2f80b0986af3a26c435b95c0

Tests

  • git diff --check: passed.
  • julia --project=reference --startup-file=no -e 'Meta.parseall(read("reference/compare.jl", String)); println("parse ok")': passed.
  • REUSE_IMAGES_TAR=1 julia --project=reference --startup-file=no reference/compare.jl: passed, 23/23 reference images.
  • julia --project=reference --startup-file=no reference/compare.jl against the currently published refimages-v2: failed, 1 passed / 22 failed, but now writes comparison artifacts instead of crashing.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 23, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.39%. Comparing base (efdbaab) to head (61e8434).
⚠️ Report is 26 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   79.93%   88.39%   +8.45%     
==========================================
  Files          10       10              
  Lines         658      905     +247     
==========================================
+ Hits          526      800     +274     
+ Misses        132      105      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kolaru
Copy link
Copy Markdown
Owner

Kolaru commented May 23, 2026

Thanks a lot for the help! It was a struggle because everything worked well locally.

It seems like that even with the correct reference image there are some small discrepancies that make the test fail.

Also with the updated setup, the image comparison is not really useful... I will have a look into those things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants