Align author names with manuscript + de-flake notebook smoke test#132
Merged
Conversation
Match the canonical author spellings from the manuscript (00_CONFIG.yml): - "Damián Martinez" -> "Damián Martínez" (surname accent) - "Bruno Saraiva" -> "Bruno M. Saraiva" (middle initial) - "Mario del Rosario" -> "Mario Del Rosario" (capitalisation) Names only; maintainer contact emails left unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Colab smoke test occasionally tripped the 300s per-cell timeout on a single matrix leg (Python 3.11) while the other legs passed in ~75s. The notebooks do network I/O (package install, structure fetch) so a slow runner can spike one cell; this is a flaky timeout, not a regression. 600s keeps the fast-failure intent (catches a hung/broken notebook) with ample headroom. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR makes two small maintenance updates: it aligns the package author names in pyproject.toml with the manuscript’s canonical spelling, and it reduces CI flakiness by increasing the per-cell timeout for the notebook smoke test workflow.
Changes:
- Update
pyproject.tomlauthor name spellings/capitalization to match the manuscript. - Increase
nbmakeper-cell timeout in the Colab notebook smoke test workflow from 300s to 600s, with added rationale in comments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Adjusts author display names (Unicode accents/middle initial/capitalization) without changing emails or other metadata. |
| .github/workflows/notebooks_smoke_test.yml | Raises --nbmake-timeout to reduce runner-variance flakes and documents the reasoning inline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
- Coverage 68.61% 68.32% -0.30%
==========================================
Files 28 28
Lines 5095 5095
==========================================
- Hits 3496 3481 -15
- Misses 1599 1614 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, independent fixes surfaced while aligning the VLab4Mic repos.
1. Author names match the manuscript
pyproject.tomlauthor spellings drifted from the canonical manuscript list (MANUSCRIPT/00_CONFIG.yml):Names only — maintainer contact emails are left as-is. (The package intentionally lists the core developers, a subset of the 8-author paper; that part is fine.)
2. De-flake the Colab smoke test
The
Notebooks - Colab smoke testfailed onmain(commit0cd1c06) with a 300s per-cell timeout — but only on the Python 3.11 matrix leg; 3.10/3.12/3.13 passed, and every normal run finishes in ~75s. The trigger commit only changed widget slider ranges, which can't cause a 5× slowdown. This is runner variance during the notebook's network I/O (pip install + structure fetch), i.e. a flaky timeout, not a regression.Raising
--nbmake-timeout300s → 600s gives ~8× headroom over a normal cell while still catching a genuinely hung/broken notebook.🤖 Generated with Claude Code