Skip to content

Align author names with manuscript + de-flake notebook smoke test#132

Merged
paxcalpt merged 2 commits into
mainfrom
fix/author-metadata-and-notebook-flake
Jun 1, 2026
Merged

Align author names with manuscript + de-flake notebook smoke test#132
paxcalpt merged 2 commits into
mainfrom
fix/author-metadata-and-notebook-flake

Conversation

@paxcalpt

@paxcalpt paxcalpt commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Two small, independent fixes surfaced while aligning the VLab4Mic repos.

1. Author names match the manuscript

pyproject.toml author spellings drifted from the canonical manuscript list (MANUSCRIPT/00_CONFIG.yml):

Was Now
Damián Martinez Damián Martínez (surname accent)
Bruno Saraiva Bruno M. Saraiva (middle initial)
Mario del Rosario Mario Del Rosario (capitalisation)

Names only — maintainer contact emails are left as-is. (The package intentionally lists the core developers, a subset of the 8-author paper; that part is fine.)

2. De-flake the Colab smoke test

The Notebooks - Colab smoke test failed on main (commit 0cd1c06) with a 300s per-cell timeout — but only on the Python 3.11 matrix leg; 3.10/3.12/3.13 passed, and every normal run finishes in ~75s. The trigger commit only changed widget slider ranges, which can't cause a 5× slowdown. This is runner variance during the notebook's network I/O (pip install + structure fetch), i.e. a flaky timeout, not a regression.

Raising --nbmake-timeout 300s → 600s gives ~8× headroom over a normal cell while still catching a genuinely hung/broken notebook.

🤖 Generated with Claude Code

paxcalpt and others added 2 commits June 1, 2026 23:24
Match the canonical author spellings from the manuscript (00_CONFIG.yml):
- "Damián Martinez"  -> "Damián Martínez"  (surname accent)
- "Bruno Saraiva"    -> "Bruno M. Saraiva" (middle initial)
- "Mario del Rosario" -> "Mario Del Rosario" (capitalisation)

Names only; maintainer contact emails left unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Colab smoke test occasionally tripped the 300s per-cell timeout on a
single matrix leg (Python 3.11) while the other legs passed in ~75s. The
notebooks do network I/O (package install, structure fetch) so a slow runner
can spike one cell; this is a flaky timeout, not a regression. 600s keeps the
fast-failure intent (catches a hung/broken notebook) with ample headroom.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 1, 2026 22:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes two small maintenance updates: it aligns the package author names in pyproject.toml with the manuscript’s canonical spelling, and it reduces CI flakiness by increasing the per-cell timeout for the notebook smoke test workflow.

Changes:

  • Update pyproject.toml author name spellings/capitalization to match the manuscript.
  • Increase nbmake per-cell timeout in the Colab notebook smoke test workflow from 300s to 600s, with added rationale in comments.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pyproject.toml Adjusts author display names (Unicode accents/middle initial/capitalization) without changing emails or other metadata.
.github/workflows/notebooks_smoke_test.yml Raises --nbmake-timeout to reduce runner-variance flakes and documents the reasoning inline.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter

codecov-commenter commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.32%. Comparing base (5b692d3) to head (889b0b3).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   68.61%   68.32%   -0.30%     
==========================================
  Files          28       28              
  Lines        5095     5095              
==========================================
- Hits         3496     3481      -15     
- Misses       1599     1614      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paxcalpt paxcalpt merged commit c0362d3 into main Jun 1, 2026
9 checks passed
@paxcalpt paxcalpt deleted the fix/author-metadata-and-notebook-flake branch June 1, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants