Manchester |26-ITP-May| Samreen Amjad |Sprint 1 | Form-Controls #1432
Manchester |26-ITP-May| Samreen Amjad |Sprint 1 | Form-Controls #1432serveyano wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
serveyano
added
📅 Sprint 1
|
In the PR description, can you format the list items in the "Self checklist" so that they appear with a checkbox like this?
For more info about formatting tasklist on GitHub, see: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-tasklists |
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is well formatted and error-free. Most requirements met. Well done.
Note:
Your formatting is already very good. Using a formatter with "Format on Save" would save you time, ensure 100% consistency, and automatically clean up things like trailing whitespace and unnecessary empty lines. This also helps keep Git diffs and pull requests cleaner by reducing formatting-only changes, making it easier to review the actual code changes.
For more info about enabling "Format on save" option on VS Code, please refer to this guide.
| <input | ||
| type="text" | ||
| id="name" | ||
| name="name" | ||
| required | ||
| minlength="2" | ||
| pattern=".*\S.*" | ||
| > |
There was a problem hiding this comment.
This input field could accept an input such as " A" (a space and an alphabet) even though the input contains only one non-space character. Can you update the code so that it meets the requirement?
cjyuan
added
Reviewed
2 participants
Learners, PR Template
Self checklist
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
Changelist
This PR creates a T-shirt order form using semantic HTML. It collects the user’s name, email, colour, and size.