Skip to content

Glasgow | 26-ITP-May | Wing Ting Huang | Sprint 2| Wireframe#1428

Open
huangwtings-hub wants to merge 1 commit into
CodeYourFuture:mainfrom
huangwtings-hub:feature/wireframe
Open

Glasgow | 26-ITP-May | Wing Ting Huang | Sprint 2| Wireframe#1428
huangwtings-hub wants to merge 1 commit into
CodeYourFuture:mainfrom
huangwtings-hub:feature/wireframe

Conversation

@huangwtings-hub

@huangwtings-hub huangwtings-hub commented Jun 8, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Wireframe updated

@netlify

netlify Bot commented Jun 8, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 071d6f5
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a26a035f88d480009a85133
😎 Deploy Preview https://deploy-preview-1428--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@huangwtings-hub huangwtings-hub added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 8, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • On Netlify, your deployed page does not quite match the Wireframe:

    • The images could not show
    • The page title is not centered
    • Articles 2 and 3 are not positioned side by side (with article 2 on the left of article 3)
    • The footer content is not centered

Can you address these issues? You will need to modify the CSS code in style.css.
Image

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants