-
-
Notifications
You must be signed in to change notification settings - Fork 501
London | 26-ITP-May | Eyob Zeray | Sprint 2 | Wireframe #1424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eyob-tech
wants to merge
3
commits into
CodeYourFuture:main
Choose a base branch
from
eyob-tech:feature/wireframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+137
−95
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,60 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| </footer> | ||
| </body> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Web Development Basics</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Understanding Web Development</h1> | ||
| <p>Learn about the tools and concepts every developer needs to know</p> | ||
| </header> | ||
|
|
||
| <main> | ||
| <article> | ||
| <img src="https://picsum.photos/seed/readme/400/200" alt="A README file displayed in a code editor" /> | ||
| <h2>What is the purpose of a README file?</h2> | ||
| <p>When you open someone's project for the first time, | ||
| the README is the first thing you read. It tells you | ||
| what the project does, why it exists, how to install it, | ||
| and how to use it. Without a README, other developers | ||
| would have no idea where to start. Writing a clear README | ||
| is one of the most important habits a developer can build.</p> | ||
| <a href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes">Read more</a> | ||
| </article> | ||
|
|
||
| <article> | ||
| <img src="https://picsum.photos/seed/wireframe/400/200" alt="A hand-drawn wireframe sketch of a webpage layout" /> | ||
| <h2>What is the purpose of a wireframe?</h2> | ||
| <p>Before writing a single line of code, designers and | ||
| developers draw a wireframe. It is a simple sketch that | ||
| shows where each part of the page will go — the header, | ||
| the images, the text, the buttons. Think of it like the | ||
| blueprint of a house. You plan before you build. A | ||
| wireframe saves time and avoids confusion later.</p> | ||
| <a href="https://en.wikipedia.org/wiki/Website_wireframe">Read more</a> | ||
| </article> | ||
|
|
||
| <article> | ||
| <img src="https://picsum.photos/seed/gitbranch/400/200" alt="A diagram showing Git branches" /> | ||
| <h2>What is a branch in Git?</h2> | ||
| <p>A branch in Git is like a safe copy of your project | ||
| where you can make changes freely. While you work on | ||
| your branch, the main code stays untouched. When your | ||
| work is finished and tested, you merge your branch back | ||
| into main. This is how developers work together without | ||
| breaking each other's code.</p> | ||
| <a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches">Read more</a> | ||
| </article> | ||
| </main> | ||
|
|
||
| <footer> | ||
| <p>This page covers README files, wireframes, and Git branches — | ||
| three essential concepts for every web developer.</p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,89 +1,104 @@ | ||
| /* Here are some starter styles | ||
| You can edit these or replace them entirely | ||
| It's showing you a common way to organise CSS | ||
| And includes solutions to common problems | ||
| As well as useful links to learn more */ | ||
|
|
||
| /* ====== Design Palette ====== | ||
| This is our "design palette". | ||
| It sets out the colours, fonts, styles etc to be used in this design | ||
| At work, a designer will give these to you based on the corporate brand, but while you are learning | ||
| You can design it yourself if you like | ||
| Inspect the starter design with Devtools | ||
| Click on the colour swatches to see what is happening | ||
| I've put some useful CSS you won't have learned yet | ||
| For you to explore and play with if you are interested | ||
| https://web.dev/articles/min-max-clamp | ||
| https://scrimba.com/learn-css-variables-c026 | ||
| ====== Design Palette ====== */ | ||
| /* ====== Design Palette ====== */ | ||
| :root { | ||
| --paper: oklch(7 0 0); | ||
| --ink: color-mix(in oklab, var(--color) 5%, black); | ||
| --ink: color-mix(in oklch, var(--color) 5%, black); | ||
| --font: 100%/1.5 system-ui; | ||
| --space: clamp(6px, 6px + 2vw, 15px); | ||
| --space: clamp(6px, 2px + 2vw, 15px); | ||
| --line: 1px solid; | ||
| --container: 1280px; | ||
| --container: 1200px; | ||
| } | ||
| /* ====== Base Elements ====== | ||
| General rules for basic HTML elements in any context */ | ||
|
|
||
| /* ====== Base Elements ====== */ | ||
| body { | ||
| background: var(--paper); | ||
| color: var(--ink); | ||
| font: var(--font); | ||
| color: var(--ink); | ||
| background: #f9f9f9; | ||
| margin: 0; | ||
| padding: 0; | ||
| padding-bottom: 80px; | ||
| font-family: system-ui, sans-serif; | ||
| } | ||
|
|
||
| h1, h2 { | ||
| margin: 0 0 8px 0; | ||
| } | ||
|
|
||
| a { | ||
| padding: var(--space); | ||
| border: var(--line); | ||
| max-width: fit-content; | ||
| display: inline-block; | ||
| padding: 8px 16px; | ||
| border: 1px solid #333; | ||
| color: #333; | ||
| text-decoration: none; | ||
| margin-top: 8px; | ||
| } | ||
|
|
||
| a:hover { | ||
| background: #333; | ||
| color: white; | ||
| } | ||
|
|
||
| a:focus { | ||
| outline: 3px solid blue; | ||
| } | ||
|
|
||
| img, | ||
| svg { | ||
| width: 100%; | ||
| height: 200px; | ||
| object-fit: cover; | ||
| display: block; | ||
| } | ||
| /* ====== Site Layout ====== | ||
| Setting the overall rules for page regions | ||
| https://www.w3.org/WAI/tutorials/page-structure/regions/ | ||
| */ | ||
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| } | ||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
|
|
||
| /* ====== Header ====== */ | ||
| header { | ||
| text-align: center; | ||
| padding: 24px 16px; | ||
| border-bottom: 1px solid #ccc; | ||
| background: white; | ||
| } | ||
| /* ====== Articles Grid Layout ==== | ||
| Setting the rules for how articles are placed in the main element. | ||
| Inspect this in Devtools and click the "grid" button in the Elements view | ||
| Play with the options that come up. | ||
| https://developer.chrome.com/docs/devtools/css/grid | ||
| https://gridbyexample.com/learn/ | ||
| */ | ||
|
|
||
| /* ====== Site Layout ====== */ | ||
| main { | ||
| max-width: 900px; | ||
| margin: 24px auto; | ||
| padding: 0 16px; | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: var(--space); | ||
| > *:first-child { | ||
| grid-column: span 2; | ||
| } | ||
| gap: 24px; | ||
| } | ||
| /* ====== Article Layout ====== | ||
| Setting the rules for how elements are placed in the article. | ||
| Now laying out just the INSIDE of the repeated card/article design. | ||
| Keeping things orderly and separate is the key to good, simple CSS. | ||
| */ | ||
|
|
||
| /* First article spans full width */ | ||
| main > article:first-child { | ||
| grid-column: span 2; | ||
| } | ||
|
|
||
| /* ====== Article Layout ====== */ | ||
| article { | ||
| border: var(--line); | ||
| padding-bottom: var(--space); | ||
| border: 1px solid #ccc; | ||
| padding: 16px; | ||
| background: white; | ||
| text-align: left; | ||
| display: grid; | ||
| grid-template-columns: var(--space) 1fr var(--space); | ||
| > * { | ||
| grid-column: 2/3; | ||
| } | ||
| > img { | ||
| grid-column: span 3; | ||
| } | ||
| } | ||
|
|
||
| article h2 { | ||
| font-size: 1.1rem; | ||
| margin: 12px 0 8px; | ||
| } | ||
|
|
||
| article p { | ||
| font-size: 0.95rem; | ||
| line-height: 1.6; | ||
| margin-bottom: 12px; | ||
| } | ||
|
|
||
| /* ====== Footer ====== */ | ||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
| width: 100%; | ||
| text-align: center; | ||
| padding: 16px; | ||
| background: #333; | ||
| color: white; | ||
| font-size: 0.9rem; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your formatting is already very good. Using a formatter with "Format on Save" would save you time, ensure 100% consistency, and automatically clean up things like trailing whitespace and unnecessary empty lines. This also helps keep Git diffs and pull requests cleaner by reducing formatting-only changes, making it easier to review the actual code changes.
For more info about enabling "Format on save" option on VS Code, please refer to this guide.