Skip to content

London | 26-ITP-May | Eyob Zeray | Sprint 2 | Wireframe#1424

Open
eyob-tech wants to merge 3 commits into
CodeYourFuture:mainfrom
eyob-tech:feature/wireframe
Open

London | 26-ITP-May | Eyob Zeray | Sprint 2 | Wireframe#1424
eyob-tech wants to merge 3 commits into
CodeYourFuture:mainfrom
eyob-tech:feature/wireframe

Conversation

@eyob-tech

@eyob-tech eyob-tech commented Jun 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Wireframe project completed. It has 3 articles with 3 different images and links.

@netlify

netlify Bot commented Jun 7, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 8cb1daf
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a27647789f65d00080e815a
😎 Deploy Preview https://deploy-preview-1424--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@eyob-tech eyob-tech added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jun 7, 2026
cjyuan
cjyuan reviewed Jun 7, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is error free and well formatted, and page layout matches the wireframe well.

  • Can you replace the images and add links to the articles so that they have different images and links (to meet one of the requirements)?

  • The checkboxes in the PR description is not yet correctly formatted in Markdown syntax. Can you fix their syntax? (Related resource: GitHub Tasklist)

Comment thread Wireframe/index.html
Comment on lines +53 to +56
<footer>
<p>This page covers README files, wireframes, and Git branches —
three essential concepts for every web developer.</p>
</footer>

@cjyuan cjyuan Jun 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your formatting is already very good. Using a formatter with "Format on Save" would save you time, ensure 100% consistency, and automatically clean up things like trailing whitespace and unnecessary empty lines. This also helps keep Git diffs and pull requests cleaner by reducing formatting-only changes, making it easier to review the actual code changes.

For more info about enabling "Format on save" option on VS Code, please refer to this guide.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 7, 2026
@eyob-tech eyob-tech added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Module-Onboarding The name of the module. labels Jun 9, 2026
@eyob-tech eyob-tech changed the title London | May - 26 | Eyob Zeray | Sprint 2 | Wireframe London | 26-ITP-May | Eyob Zeray | Sprint 2 | Wireframe Jun 9, 2026
@eyob-tech eyob-tech requested a review from cjyuan June 9, 2026 01:44
@cjyuan

cjyuan commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan Awaiting requested review from cjyuan

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyob-tech @cjyuan