Manchester| 26-ITP-May | John Robinson | Sprint 2 | Wireframe#1422
Open
JohnRob-jnr wants to merge 6 commits into
Open
Manchester| 26-ITP-May | John Robinson | Sprint 2 | Wireframe#1422JohnRob-jnr wants to merge 6 commits into
JohnRob-jnr wants to merge 6 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
JohnRob-jnr
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
JohnRob-jnr
added
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
JohnRob-jnr
added
the
Needs Review
cjyuan
reviewed
Jun 7, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code is error-free and page layout matches the wireframe well. Good job! It would probably match the wireframe better if all articles have the same padding space.
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).
-
I noticed some typo. Could you run the page content through an AI tool to identify any potential improvements, even minor ones, to help ensure the content is fully polished?
cjyuan
added
Reviewed
Contributor
|
Can you also restore the "Changelist" header in the PR description? It should be a level 2 header that looks like this: Changelist |
JohnRob-jnr
added
📅 Sprint 2
Contributor
|
Changes look good. Can you also address this comment: #1422 (comment) (Look up "How to format a level-2 header in Markdown syntax") I will mark this PR as "Complete" first. |
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manchester| 26-ITP-May | John Robinson | Sprint 2 | Wireframe
Resubmitted my Wireframe as I made an error when working on it previously that would not allow it to be submitted for a pull request
Changelist
In this commit corrected the typo, added fixed footer and formatted CSS