Skip to content

Birmingham | ITP-May-26 | Toluwalase Tiamiyu | Sprint 1 | Form Control#1416

Open
TTiamiyu wants to merge 5 commits into
CodeYourFuture:mainfrom
TTiamiyu:form-control
Open

Birmingham | ITP-May-26 | Toluwalase Tiamiyu | Sprint 1 | Form Control#1416
TTiamiyu wants to merge 5 commits into
CodeYourFuture:mainfrom
TTiamiyu:form-control

Conversation

@TTiamiyu

@TTiamiyu TTiamiyu commented Jun 5, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

In this commit i have created a form that allows users to select size, color and also has a submit button,

@netlify

netlify Bot commented Jun 5, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 4819813
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a268144dd46160008d58010
😎 Deploy Preview https://deploy-preview-1416--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@TTiamiyu TTiamiyu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jun 5, 2026
@cjyuan

cjyuan commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@TTiamiyu Since this is a continuation of your previous PR (PR#1257) and not a new PR

  • It may be helpful to note the current status of the PR in the description to prevent other reviewers from assuming it is a new submission.
  • You could tag the original reviewer in a comment and invite them to continue reviewing this PR.

@TTiamiyu

TTiamiyu commented Jun 5, 2026

Copy link
Copy Markdown
Author

The initial reviewer was tagged in the previous PR before i closed it.

@TTiamiyu

TTiamiyu commented Jun 5, 2026

Copy link
Copy Markdown
Author

Should I tag the initial reviewer again in the present PR, even if I already tagged in the old PR with the link to this new PR?

@Luro91 Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jun 6, 2026

@Luro91 Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see an accessibility score of 92 in Lighthouse. How can you get it to 100?

Image

Comment thread Form-Controls/index.html Outdated
@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 6, 2026
@Luro91

Luro91 commented Jun 6, 2026

Copy link
Copy Markdown

Should I tag the initial reviewer again in the present PR, even if I already tagged in the old PR with the link to this new PR?

I found it. As mentioned when you write a short explanation in the PR descriptions it's easier to see as mention link is a bit hidden between the other comments

@TTiamiyu

TTiamiyu commented Jun 6, 2026

Copy link
Copy Markdown
Author

@Luro91, the last couple of commits has addressed the following issues raised

  • The aria attribute was added to the html to improve the experience users that use screen readers have
  • A css file was added to improve the page style and also address the lighthouse rating.

@TTiamiyu TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
Comment thread Form-Controls/index.html Outdated
@Luro91 Luro91 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 8, 2026
@TTiamiyu TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 8, 2026

@Luro91 Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done the code works as expected

@Luro91 Luro91 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants