-
-
Notifications
You must be signed in to change notification settings - Fork 501
Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Wireframe #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3901b66
4ffae20
0931354
b529313
c9b97c3
a33cad3
183c31e
1842229
3518a91
e3b64ff
c3c0cdc
baa0fd8
cb8ac9d
de3ffd6
16a9f4b
ce52dee
e49be46
d137024
a347432
d046c14
5f92d2a
e13c36b
cbb7501
fe76aba
f413391
65ce2e1
8cf98ca
ffbfcb5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Tobias-Amaechina, why is this file empty, and could you choose a better name for your CSS stylesheet file?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @akeren , Please which of the file is empty?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The empty file has been updated and a descriptive name styles.css has been chosen There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Tobias-Amaechina, could you check the appearance of your UI and fix the issues identified 👉 https://deploy-preview-1385--cyf-onboarding-module.netlify.app/wireframe/ Examine the position of the header and footer; think about what has to change in your CSS styling
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The position of the header and footer has been changed to closely resemble the template |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,11 +31,30 @@ body { | |
| color: var(--ink); | ||
| font: var(--font); | ||
| } | ||
|
|
||
| a { | ||
| padding: var(--space); | ||
| border: var(--line); | ||
| max-width: fit-content; | ||
| } | ||
|
|
||
|
|
||
|
Comment on lines
+36
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Tobias-Amaechina, do you think this space is needed? |
||
| padding: var(--space); | ||
|
|
||
| border: var(--line); | ||
|
|
||
| border-radius: 5px; | ||
|
|
||
| text-decoration: none; | ||
|
|
||
| color: var(--ink); | ||
|
|
||
| background: color-mix(in oklab, var(--paper) 70%, white); | ||
| max-height:2rem; | ||
| max-width:4.52rem; | ||
| } | ||
|
|
||
| a:hover { | ||
| background: color-mix(in oklab, var(--paper) 50%, white); | ||
|
|
||
| } | ||
|
|
||
| img, | ||
| svg { | ||
| width: 100%; | ||
|
|
@@ -49,10 +68,25 @@ main { | |
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| } | ||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
| footer p { | ||
| font-size: 0.875rem; | ||
| color: #666; | ||
| text-align: center; | ||
| margin-bottom: 2rem; | ||
| } | ||
| footer address { | ||
| font-size: 0.875rem; | ||
| color: #666; | ||
| text-align: center; | ||
| margin-bottom: 2rem; | ||
| } | ||
| header h1 { | ||
| text-align: center; | ||
| margin-bottom: var(--space); | ||
| } | ||
| header p { | ||
| text-align: center; | ||
| margin-bottom: var(--line); | ||
| } | ||
| /* ====== Articles Grid Layout ==== | ||
| Setting the rules for how articles are placed in the main element. | ||
|
|
@@ -86,4 +120,4 @@ article { | |
| > img { | ||
| grid-column: span 3; | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tobias-Amaechina, why is the appearance of this anchor link different from the rest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akeren for spotting that, the anchor elements has been styled for uniformity