Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Wireframe#1385
Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 2 | Wireframe#1385Tobias-Amaechina wants to merge 27 commits into
Conversation
…proving the alt message for accessiblity compliance
…branch and alt message
… from readme file path section
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Tobias-Amaechina
added
the
Needs Review
|
Hello @Tobias-Amaechina, Could you please refer to the acceptance criteria section of the task? There are some missing constraints from your implementation. Here's the link 👉 https://deploy-preview-1385--cyf-onboarding-module.netlify.app/Wireframe/readme.md |
akeren
added
📅 Sprint 2
|
Thank you so much for the review and feedback I have now linked my css file with linked.css file as requested by the acceptance criteria |
There was a problem hiding this comment.
@Tobias-Amaechina, why is this file empty, and could you choose a better name for your CSS stylesheet file?
There was a problem hiding this comment.
The empty file has been updated and a descriptive name styles.css has been chosen
There was a problem hiding this comment.
@Tobias-Amaechina, could you check the appearance of your UI and fix the issues identified 👉 https://deploy-preview-1385--cyf-onboarding-module.netlify.app/wireframe/
Examine the position of the header and footer; think about what has to change in your CSS styling
There was a problem hiding this comment.
The position of the header and footer has been changed to closely resemble the template
Tobias-Amaechina
added
the
Needs Review
| In Git, a <em>branch</em> is like a separate workspace | ||
| where you can make changes and try new ideas without affecting the main project. | ||
| Think of it as a "parallel universe" for your code.</p> | ||
| <a href="https://www.w3schools.com/git/git_branch.asp?remote=github">Read more</a> |
There was a problem hiding this comment.
@Tobias-Amaechina, why is the appearance of this anchor link different from the rest?
akeren
removed
the
Needs Review
2 participants
Learners, PR Template
Self checklist
Changelist
Here are what I did
I updated HTML structure to use semantic elements .
I ensured proper heading hierarchy with
for page title and
for article titles![]()
with descriptive alt attributes for accessibility
I used
I implemented three distinct elements for content organization
I added comprehensive alt text to all images for screen reader compatibility
I ensured proper color contrast ratios throughout the design
I verified semantic HTML structure supports assistive technologies
I used meaningful link text ("Read more") for context
I implemented proper heading hierarchy for document outline
I maintained linked style.css file with all styling rules
I organized CSS with clear sections: Design Palette, Base Elements, Site Layout, Grid Layout, and Article Layout
I used CSS custom properties (--color, --space, --container, etc.) for maintainable design system
I committed changes incrementally with descriptive commit messages
I pushed branch to GitHub for code review and collaboration
I followed proper branching strategy for feature development
I created three elements with unique content:
README Purpose - with image, title, summary, and "Read more" link
Wireframe Purpose - with image, title, summary, and "Read more" link
Git Branch Definition - with image, title, summary, and "Read more" link
Each article displays placeholder images with proper styling
Positioned footer with position: fixed; bottom: 0;
Ensured footer remains at bottom of viewport while scrolling content
Added proper bottom margin to main to prevent content overlap
Implemented responsive grid layout matching wireframe design
First article spans full width (grid-column: span 2)
Two-column grid for subsequent articles (grid-template-columns: 1fr 1fr)
Maintained consistent spacing using CSS variables