London | ITPMay2026 | Mahbubur Rahman | Sprint 1 | Form Controls#1267
Open
mahbubur13 wants to merge 3 commits into
Open
London | ITPMay2026 | Mahbubur Rahman | Sprint 1 | Form Controls#1267mahbubur13 wants to merge 3 commits into
mahbubur13 wants to merge 3 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
mahbubur13
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
mahbubur13
changed the title
mahbubur13
added
the
Needs Review
|
You should also add 2 other labels to your PR. Please check which ones and please add them |
|
One thing to mention regarding your commit message "Created a folder" isn't really a relevant message. It's better to relate it to the code changes made, for example;
|
Sambuxc
reviewed
May 20, 2026
Sambuxc
reviewed
May 20, 2026
| </div> | ||
| <div> | ||
| <lable type="text" for= "email">email</lable> | ||
| <input type="email" id="email" pattern=".&@yahoo.co.uk" size="30" required /> |
There was a problem hiding this comment.
Have you tested that this pattern works?
There was a problem hiding this comment.
@mahbubur13 Have you seen this comment?
Author
There was a problem hiding this comment.
I have corrected the email verification
Sambuxc
reviewed
May 20, 2026
Sambuxc
added
Review in progress
Contributor
|
@Sambuxc @mahbubur13 |
mahbubur13
added
Needs Review
Sambuxc
reviewed
Jun 5, 2026
| </div> | ||
| <div> | ||
| <lable type="text" for= "email">email</lable> | ||
| <input type="email" id="email" pattern=".&@yahoo.co.uk" size="30" required /> |
There was a problem hiding this comment.
@mahbubur13 Have you seen this comment?
Sambuxc
added
Reviewed
mahbubur13
added
Complete
Contributor
Currently, it is not immediately clear if you have addressed the latest comments: #1267 (review) Note: Leaving a comment in the comment box at the bottom of the page can help preserve the conversation in a chronological timeline. |
Author
|
I have checked all the comments and implemented all the changes required @Sambuxc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I completed the for assignment