-
-
Notifications
You must be signed in to change notification settings - Fork 501
Birmingham|26-ITP-May|Yonas Gebre|Sprint 1|Form Control #1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yonasdesbelegebre
wants to merge
12
commits into
CodeYourFuture:main
Choose a base branch
from
yonasdesbelegebre:yonas-form
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+134
−12
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
778e937
the html format only
haftomprogrammer 304b08c
Style added for the forms
yonasdesbelegebre c70d30f
modify the name label
yonasdesbelegebre 2f0ee3b
color performance optimization
yonasdesbelegebre f409355
add div for labels
yonasdesbelegebre 55ffbef
modified the form color and perofrmance desktop
yonasdesbelegebre a82cab3
modifed feedbacks
yonasdesbelegebre 1bcb7c1
email includes more characters
yonasdesbelegebre df00e2f
radio button error
yonasdesbelegebre a72d6c6
added label for the select
yonasdesbelegebre 03ed0e7
customer name fixed
yonasdesbelegebre af88358
trying to fix
yonasdesbelegebre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good job that you separated the CSS into its own file—that’s an excellent best practice and will make your code much easier to read, debug, and maintain as it grows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* body style */ | ||
| input:valid{ | ||
| border:2px solid yellow; | ||
| } | ||
| input:invalid:not(:placeholder-shown){ | ||
| border:2px solid red; | ||
| } | ||
| body { | ||
| background-color: lightwhite; | ||
| max-width: 800px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| padding: 25px; | ||
| } | ||
|
|
||
| header h1 { | ||
| color: #2c3e50; | ||
| margin-bottom: 15px; | ||
| } | ||
|
|
||
| form { | ||
| background: skyblue; | ||
| padding: 30px; | ||
| border-radius: 8px; | ||
| box-shadow: 0 4px 15px rgba(0, 0, 0, 0.1); | ||
| width: 100%; | ||
| max-width: 400px; | ||
| } | ||
| input:focus { | ||
| border-color: #3498db; | ||
| outline: none; | ||
| } | ||
| /* Labels and Inputs */ | ||
| label { | ||
| display: block; | ||
| margin-top: 15px; | ||
| margin-bottom: 5px; | ||
| font-weight: 600; | ||
| font-size: 0.9rem; | ||
| } | ||
|
|
||
| input[type="text"], | ||
| input[type="email"], | ||
| select,button { | ||
| align-items: right; | ||
| width: 100%; | ||
| padding: 10px; | ||
| border: 2px solid #ddd; | ||
| border-radius: 6px; | ||
| box-sizing: border-box; /* Ensures padding doesn't break width */ | ||
| transition: border-color 0.3s ease; | ||
| } | ||
|
|
||
| .radio { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 5px; | ||
| font-weight: normal; | ||
| } | ||
| #submit { | ||
| background-color: #3498db; | ||
| margin-top: 15px; | ||
| border: none; | ||
| cursor: pointer; | ||
| font-size: 1rem; | ||
| } | ||
|
|
||
| /* Footer */ | ||
| footer { | ||
| margin-top: 20px; | ||
| font-size: 0.8rem; | ||
| color:black; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there changes in this file? How is it related to the task?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, could you make it clear. Did you need more explanation about the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You commited some change to Form-Controls/README.md which I don't understand.