LRIS2 wdl files to drive the Bonn shutter#6
Merged
Merged
Conversation
mikelangmayr
changed the title
prkrtg
approved these changes
Jun 8, 2026
Contributor
|
sorry I missed this earlier. Sure, this may drive the Bonn Shutter, but basically everything else in those files is extraneous... LRIS2 doesn't even use a H2RG type detector, so why have we merged in all the timing scripts from cryoscope here? There are like 2 lines in the OpenShutter() and CloseShutter() routines that are needed. The rest should not be there - including things like not having the correct module configurations for the LRIS2 archons (for instance this config puts an LVDS module in slot 11 which is actually a HeaterX module in LRIS-2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WhatsApp.Video.2026-03-10.at.11.22.52.mp4