[PWGEM/Dilepton] remove unnecessary variables #28484
Annotations
10 errors, 1 warning, and 2 notices
|
[magic-number]:
PWGEM/Dilepton/Utils/ElectronModule.h#L822
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGEM/Dilepton/Utils/ElectronModule.h#L751
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGEM/Dilepton/Utils/ElectronModule.h#L731
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[magic-number]:
PWGEM/Dilepton/Utils/ElectronModule.h#L716
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[pdg/explicit-code]:
PWGEM/Dilepton/Utils/ElectronModule.h#L751
Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
|
|
[name/configurable]:
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSCT.cxx#L93
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
[name/workflow-file]:
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSCT.cxx#L1
Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
|
|
[name/o2-task]:
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSCT.cxx#L1
Specify task name only when it cannot be derived from the struct name. Only append to the default name.
|
|
[name/o2-task]:
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSCT.cxx#L282
Specified task name associate-ambiguous-electron and the struct name associateAmbiguousElectron produce the same device name associate-ambiguous-electron. TaskName is redundant.
|
|
[name/o2-task]:
PWGEM/Dilepton/TableProducer/skimmerPrimaryElectronSCT.cxx#L281
Device names skimmer-primary-electron-sct and skimmer-primary-electron-s-c-t generated from the specified task name skimmer-primary-electron-sct and from the struct name skimmerPrimaryElectronSCT, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to SkimmerPrimaryElectronSct and removing TaskName.
|
|
O2 linter
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: thollander/actions-comment-pull-request@v3. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|