Skip to content

Commit 225b8d6

Browse files
committed
obsolete FIXME; use helpers where required
1 parent 3709d6e commit 225b8d6

3 files changed

Lines changed: 3 additions & 7 deletions

File tree

Framework/Core/include/Framework/ASoA.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1521,7 +1521,7 @@ consteval static bool relatedBySortedIndex()
15211521

15221522
namespace o2::framework
15231523
{
1524-
/// FIXME: has to track origin to handle the correct arguments
1524+
/// tracks origin in bindingKey matcher to handle the correct arguments
15251525
struct PreslicePolicyBase {
15261526
const std::string binding;
15271527
Entry bindingKey;

Framework/Core/src/AnalysisSupportHelpers.cxx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,7 @@ void AnalysisSupportHelpers::addMissingOutputsToBuilder(std::vector<InputSpec> c
175175
// FIXME: until we have a single list of pairs
176176
additionalInputs |
177177
std::ranges::views::filter([](InputSpec const& input) {
178-
return DataSpecUtils::partialMatch(input, AODOrigins) || std::ranges::any_of(input.metadata, [](ConfigParamSpec const& p) {
179-
return p.name.starts_with("aod-origin-replaced");
180-
});
178+
return DataSpecUtils::partialMatch(input, AODOrigins) || std::ranges::any_of(input.metadata, checks::has_params_with_name_starting("aod-origin-replaced"));
181179
}) |
182180
std::ranges::views::filter([](InputSpec const& input) {
183181
return std::ranges::none_of(input.metadata, [](ConfigParamSpec const& p) { return (p.name.compare("projectors") == 0) || (p.name.compare("index-records") == 0); });

Framework/Core/src/ArrowSupport.cxx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -712,9 +712,7 @@ o2::framework::ServiceSpec ArrowSupport::arrowBackendSpec()
712712
for (auto& d : workflow) {
713713
d.inputs |
714714
std::ranges::views::filter([](InputSpec const& input) {
715-
return DataSpecUtils::partialMatch(input, AODOrigins) || std::ranges::any_of(input.metadata, [](ConfigParamSpec const& p) {
716-
return p.name.starts_with("aod-origin-replaced");
717-
});
715+
return DataSpecUtils::partialMatch(input, AODOrigins) || std::ranges::any_of(input.metadata, checks::has_params_with_name_starting("aod-origin-replaced"));
718716
}) |
719717
sinks::update_input_list{dec.requestedAODs};
720718
}

0 commit comments

Comments
 (0)